Rocket.chat: User context menu doesn't contain "Administration" anymore, nor does the "three-dots" menu

[TwizzyDizzy]

Description:

I have given the [manage-emoji] permission to normal users. This lead to them having an "Administration" menu with only one option: to add custom emojis.

With the new discovery menu, this option is not contained in the Status menu and it is not available as extended options in the menu ("three-dots menu" - which isn't even present, only the add channel [+]).

So currently it is not possible to access the custom emoji interface from the normal menu despite having the respective privileges.

Cheers
Thomas

Server Setup Information:

• Version of Rocket.Chat Server: 0.62.0
• Operating System: Oracle Linux 7
• Deployment Method(snap/docker/tar/etc): tar
• Number of Running Instances: 1
• DB Replicaset Oplog: -
• Node Version: 8.9.4
• mongoDB Version: 2.6.12

Steps to Reproduce:

1. Please see image below

Expected behavior:

• Give a possibility to access the administration menu, if you have the [manage-emoji] permission.

Actual behavior:

Relevant logs:

-

[TwizzyDizzy]

This is still present in 0.62.0

[c0dzilla]

@karlprieb may I send a pr for this? :)

[TwizzyDizzy]

Hey, @karlprieb, could you have a look at this PR? :)

Cheers
Thomas

[karlprieb]

@TwizzyDizzy this PR was approved already, just waiting to be merged.

[a-bern]

Hi @karlprieb and @TwizzyDizzy,
this looks broken by design. Imho if a user has any admin permission he should be able to see the admin menu as long as the user is only able to see/modify the settings where he has permissions too. For example with "manage-emoji" he should not see the integrations.

Why is the admin menu only visible for specific permissions?

Take a look at issue #10226 - and I guess there will be more..
Thanks,
Alex

[TwizzyDizzy]

I have to say that I agree with @a-bern. A very legit remark. Just had a look at the PR. This seems to be rather prone to future admin permissions walking into the same issue just by simply being forgotten there.

I tend to think, that it would be more clever (disclaimer: I have NO nodejs or Rocket.Chat coding experience, yet other languages) to make this ("this is an admin-setting and therefore needs to trigger the menu in the UI") a property of a permission and then only set this flag when you define that setting once?

Then on checking whether this should be shown or not, just walk through the list of permissions the user has and set userHasOneAdminPermission to 1 if one setting has this property. Then only show the admin-menu, when userHasOneAdminPermission == 1.

Hope this is understandable...

But indeed I have the feeling, that if you do it the way you're currently doing it, this kind of issue is gonna appear again and again.

Cheers
Thomas

[a-bern]

Hi @rodrigok
Could you please explain why you closed this issue? The main problem is still not fixed.
Users with "manage-integrations" for example permissions are still not able to see the admin menu.

Should we open a separate issue for each permission that requires the admin menu?

Thanks

Alex