Rn-fetch-blob: `progress` dose no work in iOS because`setProgress` will call before `sendRequest`

Created on 2 Jul 2018 · 8Comments · Source: joltup/rn-fetch-blob

When I fetch a file like that:

FetchBlob
    .fetch('GET','xxx')
    .progress({ interval : 250},(receive,total)=>{
      console.log("progress", receive/total)
    })

I can't receive progress because progress will be called synchronization with fetch.

In iOS:

fetch will call :

RCT_EXPORT_METHOD(fetchBlob:(NSDictionary *)options
                  taskId:(NSString *)taskId
                  method:(NSString *)method
                  url:(NSString *)url
                  headers:(NSDictionary *)headers
                  body:(NSString *)body callback:(RCTResponseSenderBlock)callback)

progress will call:

RCT_EXPORT_METHOD(enableProgressReport:(NSString *)taskId interval:(nonnull NSNumber*)interval count:(nonnull NSNumber*)count)

The fetchBlob function will async create an request obj.
Before the buildOctetRequest 's onComplete is called ,enableProgressReport has already been called.
Caused enableProgressReport can't find taskID

RCT_EXPORT_METHOD(fetchBlob:(NSDictionary *)options
                  taskId:(NSString *)taskId
                  method:(NSString *)method
                  url:(NSString *)url
                  headers:(NSDictionary *)headers
                  body:(NSString *)body callback:(RCTResponseSenderBlock)callback)
{
    [RNFetchBlobReqBuilder buildOctetRequest:options
                                      taskId:taskId
                                      method:method
                                         url:url
                                     headers:headers
                                        body:body
                                  onComplete:^(NSURLRequest *req, long bodyLength)
    {
        // something went wrong when building the request body
        if(req == nil)
        {
            callback(@[@"RNFetchBlob.fetchBlob failed to create request body"]);
        }
        // send HTTP request
        else
        {
            [[RNFetchBlobNetwork sharedInstance] sendRequest:options
                                               contentLength:bodyLength
                                                      bridge:self.bridge
                                                      taskId:taskId
                                                 withRequest:req
                                                    callback:callback];
        }
    }];
}

bug help wanted

Source

MJXin

Most helpful comment

I have to do like this

let fetchobj = FetchBlob.fetch(
      'GET',
      'xxxx'
    )

    setTimeout(()=>{
      fetchobj.progress({ interval: 250},(resive,total)=>{
        console.log("progress", resive/total)
      })
    }, 0)

    fetchobj.then((res)=>{
      console.log("res", res)
    })

MJXin on 2 Jul 2018

👍9 ❤2 🎉2

All 8 comments

I have to do like this

let fetchobj = FetchBlob.fetch(
      'GET',
      'xxxx'
    )

    setTimeout(()=>{
      fetchobj.progress({ interval: 250},(resive,total)=>{
        console.log("progress", resive/total)
      })
    }, 0)

    fetchobj.then((res)=>{
      console.log("res", res)
    })

MJXin on 2 Jul 2018

👍9 ❤2 🎉2

I'm having the same issue and @MJXin's workaround fixed it.

diegolmello on 11 Jul 2018

I've also had uploadProgress stop working similarly.

milesmatthias on 12 Jul 2018

I've also had uploadProgress stop working similarly.

qiaolin-pan on 6 Aug 2018

the same problem, but @MJXin's workaround not fixed for me.

this.lastRNBFTask = RNFetchBlob.config({
            // response data will be saved to this path if it has access right.
            path: tempCacheFile,
        })
            .fetch(
                ...
            );

            setTimeout(()=>{
              this.lastRNBFTask.progress({ interval: 250},(received ,total)=>{
                console.log(received / total);
              })
            }, 0);

        this.lastRNBFTask
            .then(async (res) => {
               ...
            })
            .catch(async (error) => {
               ...
            });

RN-Fetch-Blob: v0.10.12
RN: v0.55.4
OS: iOS 11.4