Rmwc: autoFocus on Select throws TypeError

Created on 21 Mar 2019  路  3Comments  路  Source: jamesmfriedman/rmwc

When adding autoFocus to a Select:

      <Select
        label="Standard"
        options={["Cookies", "Pizza", "Icecream"]}
        autoFocus
      />

an exception is thrown:

Uncaught TypeError: Cannot read property 'handleFocus' of undefined
    at SelectBase.handleFocus (VM6984 index.js:417)
    at HTMLUnknownElement.callCallback (VM7030 react-dom.development.js:149)
    at Object.invokeGuardedCallbackDev (VM7030 react-dom.development.js:199)
    at invokeGuardedCallback (VM7030 react-dom.development.js:256)
    at invokeGuardedCallbackAndCatchFirstError (VM7030 react-dom.development.js:270)

https://codesandbox.io/embed/yp8kr097qz

This does not appear to happen for TextField, but for many components, autoFocus appears to trigger the handleFocus callback before the foundation has been initialized.

I've also run into this general class of issue using LineRipple directly:

onFocus = () => {
  if (this._lineRipple) this._lineRipple.foundation_.activate();
  // ...
};

render() {
  return (
    <div onFocus={ this.onFocus }>
      <textarea />
      <LineRipple ref={ lineRipple => this.lineRipple = lineRipple } />
    </div
  );
}

I'm making a big jump from RMWC 3.x where this code previously worked, but it seems like the foundation is now initialized at a later point.

bug

Most helpful comment

Thanks for reporting this. I鈥檒l take a pass through and make sure all form based components allow autoFocus and back it up with some tests.

All 3 comments

Thanks for reporting this. I鈥檒l take a pass through and make sure all form based components allow autoFocus and back it up with some tests.

i have component with a TextField that does trigger TypeError: Cannot read property 'handleFocus' of undefined

fixed in 5.4.0

Oddly enough, I added some tests prior to fixing it and could never get them to fail, but the issue is indeed fixed now.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kctang picture kctang  路  7Comments

danielmahon picture danielmahon  路  3Comments

nicholaschiang picture nicholaschiang  路  4Comments

UFOMelkor picture UFOMelkor  路  6Comments

rboei picture rboei  路  4Comments