Rmwc: TextField: Helptext renamed to HelperText

Created on 14 Dec 2017  路  6Comments  路  Source: jamesmfriedman/rmwc

What RMWC Version are you using?

0.0.1-rc11

What browser(s) and React Version is this bug affecting?

every

What build system are you using?

webpack

What are the steps to reproduce the bug?

<TextFieldHelpText>Optional help text.</TextFieldHelpText>

What is the expected/actual behavior?

-<p class="mdc-text-field-helptext" aria-hidden="true">Optional help text.</p>
+<p class="mdc-text-field-helper-text"" aria-hidden="true">Optional help text.</p>

Any other information you believe would be useful?

See material-components/material-components-web#1576

Most helpful comment

Thanks @j-o-d-o, I appreciate the help. I'm really just looking for another set of eyes so I don't miss anything. A couple of times I published a major bug to NPM, and I'm looking to avoid that.

All 6 comments

Hi, yes this WILL be an issue. The mcw commit will be in the upcomming 0.28.0 mcw version. rmwc is currently still on 0.26.0 mcw.
I am sure it is on @jamesmfriedman bucked list to always keep up with the latest mcw version. But the mcw release cycle is quite quick (2 weeks) and usually with quite a bit of breaking changes, so I understand that it can not always happen immediately.
Your PR definitely helps to make things easier to account for all the breaking changes! I would suggest leaving this issue open till the PR is merged and maybe add a little notice to the PR that it should be merged when rmwc will update mcw version to 0.28.0.

Following the changelog this has shipped with v0.26.0 (or I am misreading something).

YES, it says 13 Nov on the commit, I somehow read 13 Dez ... sorry. Should be merged now!

Just looked through the changelog for v27. So many things...

I鈥檒l get this PR merged in and then. I鈥檓 going to do a PR and include some active people on it or 27.

I think for most of the stuff we don't really need to do anything, e.g. api changes or mixin changes/usages. But I am happy to help, just assign me some stuff to do.

Thanks @j-o-d-o, I appreciate the help. I'm really just looking for another set of eyes so I don't miss anything. A couple of times I published a major bug to NPM, and I'm looking to avoid that.

Was this page helpful?
0 / 5 - 0 ratings