Rise: CCS styling is not removed when we get into the notebook view

Created on 24 Apr 2019  路  2Comments  路  Source: damianavila/RISE

Here: https://github.com/damianavila/RISE/blob/master/rise/static/main.js#L496-L502

We are allowing to inject css stuff, and that css is applied when we enter the slideshow view, but when we go back to the notebook view, that css is still applied which could, in turn, make the notebook view look very weird depending on the css changes you introduced.
This can be actually checked with the current example/README.ipynb

cc @parmentelat, I am pretty sure you will be interested in this since you modified the example recently.

We could probably disable the link when we go out from the slide view.
Not a blocker for the release, but I found out this testing the example and I think it would be nice to fix it in the future...

Low Severity bug

All 2 comments

that makes perfect sense indeed, I have never had to disable css code before, will be interesting :)

this should be fixed by now

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ChrisRackauckas picture ChrisRackauckas  路  6Comments

nipuli picture nipuli  路  4Comments

neighthan picture neighthan  路  3Comments

kelmouloudi picture kelmouloudi  路  3Comments

damianavila picture damianavila  路  3Comments