Revolution: Deleting resources - small bugs
- With the new button "quick create button" (https://github.com/modxcms/revolution/pull/13774) you can create children resources and publish them in the deleted parent resource, then delete them all if you empty the trash.
It is logical to remove the quick button from deleted resources: .x-tree-node-el.deleted .modx-tree-node-btn-create {display: none;}
- You can restore only a children resource in the trash manager (it disappear from the list in trash manager), but the parent will not be restored. And if you click "Purge resource", then everything will be deleted, but the message will be only about the parent.
Need a connection between deleted resources - parent and children.
It makes sense to activate and freeze the setting "Deleted" in children resources until the parent is deleted OR restore parent if children been restored OR change the parent to 0 and set the resource to unpublised, if it has been restored and its parent has been deleted.
p.s. It is odd that you can create or restore a children resource if the parent has been deleted.
Ruslan-Aleev
All 4 comments
I don't think that 2. could be solved nice. Purge them too could be too harsh. We need some 'search for orphan resources' processor otherwise, since those resources can't be found in the tree after purging.
Deleted parents and not deleted children could happen in other circumstances too.
Jako
on 7 Jan 2019
I just checked that on a current installation. The child resources are purged too, even if they are not deleted. They don't stay as orphaned resources. So the child resources 'just' have to be listed in the trash manager.
Jako
on 10 Jan 2019
@Jako Hello! Can you fix it
Ibochkarev
on 4 Sep 2019
Now there is a problem in that if you delete a resource through its setting, then its child resources will be deleted, but at the same time they will be marked as not deleted in the tree, which can confuse users.
Although if you delete via the context menu, the child resources will also be marked as deleted.
If you have a large resource tree and a lot of deleted resources in the trash, then you may simply not understand what will be deleted, which is a serious problem.
I think that it is necessary to mark child resources deleted if the parent has been deleted (as delete works through the context menu now)
A detailed discussion was here https://github.com/modxcms/revolution/pull/14350
Ruslan-Aleev
on 26 Sep 2019
Related issues
travisbotello
路
3Comments
Ruslan-Aleev
路
3Comments
netProphET
路
3Comments
akimsullec
路
4Comments
jpdevries
路
3Comments
Most helpful comment
Now there is a problem in that if you delete a resource through its setting, then its child resources will be deleted, but at the same time they will be marked as not deleted in the tree, which can confuse users.
Although if you delete via the context menu, the child resources will also be marked as deleted.
If you have a large resource tree and a lot of deleted resources in the trash, then you may simply not understand what will be deleted, which is a serious problem.
I think that it is necessary to mark child resources deleted if the parent has been deleted (as delete works through the context menu now)
A detailed discussion was here https://github.com/modxcms/revolution/pull/14350