Revolution: settings grid per-page logic is flawed

Created on 3 Mar 2017  路  3Comments  路  Source: modxcms/revolution

Summary

Settings grids are showing 30 results per page unless system setting default_per_page is > 30.

Step to reproduce

Set system setting default_per_page to 10, or 20.

Observed behavior

System setting grids show 30 results per page.

Expected behavior

Settings grids should show the number of results per page as configured with default_per_page setting.

Environment

All.

bug

Most helpful comment

i guess technically it should honour the default_per_page setting. From a usability perspective I can't imagine the scenario where I would want to lower the limit < 30

All 3 comments

Existing "bug" effectively places a minimum of 30 results on the settings grids. Perhaps this is desired? Will changing this be too much of a shock to people?

i guess technically it should honour the default_per_page setting. From a usability perspective I can't imagine the scenario where I would want to lower the limit < 30

Perhaps a better solution would be to have a setting for minimum value on this grid, and it could default to 30. Based on feedback, this doesn't sound too critical, so I'll close.

Was this page helpful?
0 / 5 - 0 ratings