Revolution: Make Installer always top menu item

[sepiariver]

Screenshot: http://sepiariver.co/1nF7Xav

The "Installer" is arguably the most important or at least it's different enough from the installed components that it should some how be demarcated.

[rtripault]

I guess there is not much we could do about this, but that rather would mean action taken from third party components developers.

To "sort" menus, there is a modMenu.menuindex column, which is supposed to store the order of the menu. It defaults to 0, so all sub menus of the "Extras" menu will have the same menuindex (unless developers wrote their installer not to do so), so sub menus will then be sorted alphabetically.

Hope it makes sense

[argnist]

Sub menus are not sorted alphabetically at all. The SQL query that creates this submenu:

SELECT `modMenu`.`text`, `modMenu`.`parent`, `modMenu`.`action`, `modMenu`.`description`, `modMenu`.`icon`, `modMenu`.`menuindex`, `modMenu`.`params`, `modMenu`.`handler`, `modMenu`.`permissions`, `modMenu`.`namespace`, Action.controller AS action_controller, Action.namespace AS action_namespace FROM `modx_menus` AS `modMenu` LEFT JOIN `modx_actions` `Action` ON `modMenu`.`action` =  `Action`.`id` WHERE `modMenu`.`parent` = 'components' ORDER BY `modMenu`.`menuindex` ASC

They are sorted in order of inserting to database as I see if menuindex=0. So this is a strange behaviour when some components are inserted before the Installer.

[OptimusCrime]

Is this a wontfix/cantfix then?

[alroniks]

@OptimusCrime I agreed with @argnist It should be fixed. In top menu we have dropdown, but I hope in future versions it will the simple link to installer, but now Intaller should be first always to avoid confusing users.

[sottwell]

I know this came up some time ago, I thought it got fixed? Is this a regression?

[sebastian-marinescu]

I just wanted to open a new feature-request about this and then this showed up in the suggestions.

So yeah, this is still very annoying. I find myself very often "searching" for this entry...
Then I go to the menu-management and drag it up. After some updates to extras, I have to search again, because it is again on a completely different position.

I've just tested via phpmyadmin to give the installer-entry a menuindex of -1, but that doesn't seem to work. So I thought I'd give it a position of 100 - so it always sticks to the bottom - that get's changed when dragging around another menu-entry, because then all entries all of a sudden get a numbered menuindex. But at least on new entries this would still be at the bottom.

So how about this as a workaround?

[sebastian-marinescu]

Okay, I'm doing it. Do you @JoshuaLuckers think a menuindex of "10" should be sufficient?

[Ruslan-Aleev]

@sebastian-marinescu It seems to me that it is better to reorganize the menu already for MODX3, look, maybe you will have some suggestions yet - https://github.com/modxcms/revolution/issues/14291

[sebastian-marinescu]

@Ruslan-Aleev Thanks for pointing me to that, I'll check it out.

Until MODX3 there is still an unforeseeable time, and in this time also new users will come to MODX2, and maybe MODX2 will also be longer around than expected - so in my opinion this is still a valid issue until a new major will be released this should and can be "fixed" at least for new MODX2 installations.

[Mark-H]

Putting it at the bottom is not very great. :(

What I'd suggest we try (I haven't looked at the relevant code yet) is to add some extra code into the menu builder that makes sure the installer is always first.

Something like an ORDER BY field(modMenu.key, 'installer') ASC (but in xPDO) before the menuindex sort is applied.

[sottwell]

Or just have the Installer, then add the menu after it. LIke hard-coding an li element into the outerTpl of pdoMenu.

[sebastian-marinescu]

I agree that it's not ideal, but at least better than always searching inside the list for it.

Both of your suggestions sound apparently better, if this can be accomplished.

[sebastian-marinescu]

I've added a new commit to https://github.com/modxcms/revolution/pull/14482 that will put the installer-entry always to the top.

[Ibochkarev]

Related #14482

[sebastian-marinescu]

Yeah, it still awaits reviews by @Mark-H and @opengeek

[jaygilmore]

I'm not sure if anyone's reviewed this lately but this does feel like a quick win fix that could either go in 2 or 3.