Retroarch: No exit on error when launched with command line arguments

Created on 14 Jul 2020 · 9Comments · Source: libretro/RetroArch

First and foremost consider this:

Only RetroArch bugs should be filed here. Not core bugs or game bugs
This is not a forum or a help section, this is strictly developer oriented

Description

Running Retroarch v1.8.9 on RPi from the command line does not exit when the core exits for some reasons (missing bios, cannot load content, ...)

Expected behavior

When launched from the command line to execute a single task, Retroarch must quit on error. This is the default behavior up to v1.8.8 (tested).

Actual behavior

Retroarch's menu opens. Only the keyboard is active. Configured pads/joysticks are all inactive.

Steps to reproduce the bug

Run a core with content it can't open:
/usr/bin/retroarch --verbose -L /usr/lib/libretro/whatever_core.so --config whatever_config.cfg whatever_invalid_rom.ext

Version/Commit

Issue happened in Retroarch v1.8.9. Everything was fine until this version.

Environment information

OS: Buildroot Linux (Recabox) on multiple platforms: RPi, Odroid Xu4, x86/x64, ...
Compiler: Cross compiler GCC 7.5.3

Source

bkg2k

Most helpful comment

Ah, that's great - thanks! I can see why that would change things.

I'll see if I can rework that as a command line option.

jdgleaver on 15 Jul 2020

👍5

All 9 comments

The behavior was changed as a result of https://github.com/libretro/RetroArch/pull/10874.

cmitu on 14 Jul 2020

That means retroarch can no longer be launched from a top-level frontend.

We will have to patch to revert the "fix" from https://github.com/libretro/RetroArch/pull/10874 or keep the 1.8.8. Both solutions are not what I was expecting for :(

bkg2k on 14 Jul 2020

the third option would be to make a case for the old behavior and discuss how we might reconcile the benefits of that commit with the need to exit-on-error.

hizzlekizzle on 14 Jul 2020

Adding a new command line argument, say '--exit-on-error' for example, to get the old exit-on-error behavior, could be an elegant third solution, I agree.

bkg2k on 14 Jul 2020