Retroarch: Shaders not working on iOS
Commit b347b26d61ac6144e72d120896042f4ae06f4421 breaks shaders on iOS 11 & 12...
Reverted this commit by hand and now shaders work fine again !
Sadly, this commit is definitely a regression...
WeedyWeedSmoker
All 9 comments
How are shaders broken for you?
orbea
on 25 Apr 2019
The shaders option just doesn't appear in the app menu since this commit, and appear fine after removing it
WeedyWeedSmoker
on 25 Apr 2019
@twinaphex Can you please look at this?
orbea
on 26 Apr 2019
Sure, I can take a look.
twinaphex
on 26 Apr 2019
@WeedyWeedSmoker
See if this fixes it -
https://github.com/libretro/RetroArch/commit/1f53eea4ee980cc26a8cef385944521ab2052e82
twinaphex
on 26 Apr 2019
Wow, that was quick !
It fixes it beautifully, @twinaphex, thanks !
_BTW, as an unrelated note, the "Release" configuration for the iOS 10 and iOS 11 pbxproj doesn't include "../../deps/rcheevos/include", which makes it fail at compilation time... The iOS 10 and iOS 11 static seem to be missing way more files..._
WeedyWeedSmoker
on 26 Apr 2019
It might be worth adding iOS to travis to catch these problems. I think it should be possible, but as I don't know much about the iOS build process it might be better if someone who used that platform helped there. :)
Could you make a new issue for this at least?
orbea
on 26 Apr 2019
@orbea Ok ! I'll close this issue then...
WeedyWeedSmoker
on 26 Apr 2019
@orbea Good idea about adding iOS targets for Travis.
twinaphex
on 26 Apr 2019
Related issues
Chocobubba
路
3Comments
blackman91
路
3Comments
fr500
路
3Comments
Alex793
路
3Comments
parkerlreed
路
3Comments