The idea is to create an issue and PR template so that it's much easier to report bugs and to lay down some basic requirements for a PR.
P.S: The idea is not to scare people away from reporting issues or raising PR's though.. ๐ป
Hey @sidthesloth92 :wave:,
Thank you for opening an issue. We will get back to you as soon as we can. Also, check out our Open Collective and consider contributing financially.
https://opencollective.com/responsively
PS.: We offer
prioritysupport for all financial contributors. Don't forget to addprioritylabel once you start contributing :smile:
๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐ ๐
Hi there! ๐
To expedite issue processing please search open and closed issues before submitting a new one. Existing issues often contain information about workarounds, resolution, or progress updates.
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
^^^
_Will be commented out. Only the creator of the issue can see it._
A clear and concise description of the problem. _<-- Will be commented out. Only the creator of the issue can see it._
Did this behavior use to work in the previous version? _<-- Will be commented out. Only the creator of the issue can see it._
Clear steps to re-produce the issue. _<-- Will be commented out. Only the creator of the issue can see it._
Press Ctrl/Cmd + F1 and paste it here.
A clear and concise description of the problem or missing capability. _<-- Will be commented out. Only the creator of the issue can see it._can see.
If you have a solution in mind, please describe it. _<-- Will be commented out. Only the creator of the issue can see it._
Have you considered any alternative solutions or workarounds? _<-- Will be commented out. Only the creator of the issue can see it._
Please link the related issue. Use # before the issue number and use the verbs 'fixes', 'resolves' to auto-link it, for eg, Fixes: #498 _<-- Will be commented out. Only the creator of PR can see._
Please provide a description of your solution if it is not clear in the related issue or if the PR has a breaking change. If there is an interesting topic to discuss or you have questions or there is an issue with electron or another library that you have used. _<-- Will be commented out. Only the creator of PR can see._
Please include screenshots or gif to showcase the final output. Also, try to explain the testing you did to validate your change. _<-- Will be commented out. Only the creator of PR can see._
@manojVivek @jjavierdguezas Certain lines will be commented out in the actual issue/PR. I just added them here for review. Once we have finalized the verbiage, I'll create a PR for the same.
@sidthesloth92 For the pull request format, most of this info will already be there on the referenced issue. So should we need these added again?
Totally valid, I'll remove some of the stuff from the Issues.
@manojVivek I've leaned it down.
@sidthesloth92 To be honest, it still feels like too much information to me. ๐ Questions inline.
๐ PR Type
What kind of change does this PR introduce?
Can we change this to something like "reference issue"? So that we can have the issue linked to the PR.
โ๏ธ PR Checklist
Please check if your PR fulfils the following requirements:
- [x] The commit message follows our guidelines
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
I feel these are valid only after the standards have been defined and followed. We don't have a commit message guidelines. And we don't have base unit-test scenarios setup. I feel these points will be effective only after those things are in place.
๐ What is the new behaviour?
This will be covered in the referenced issue too right?
@jjavierdguezas Please let us know your thoughts too.
@manojVivek @sidthesloth92
The bug/feature templates are ok to me
I agree with @manojVivek about the PR template, for now we just need these points:
I think we can see the other things in the commits
@manojVivek and @jjavierdguezas All done.. :D Thanks for your inputs.. ๐๐ฝ @manojVivek The checklist was more for the future, we will soon get there.. ๐ก๏ธ
@sidthesloth92 It looks good now, please let's go ahead.
We can tweak it by observing the usage.
Most helpful comment
@sidthesloth92 To be honest, it still feels like too much information to me. ๐ Questions inline.
Can we change this to something like "reference issue"? So that we can have the issue linked to the PR.
I feel these are valid only after the standards have been defined and followed. We don't have a commit message guidelines. And we don't have base unit-test scenarios setup. I feel these points will be effective only after those things are in place.
This will be covered in the referenced issue too right?
@jjavierdguezas Please let us know your thoughts too.