Renovate: Gradle plugins not handled

[niclastegner]

What Renovate type are you using?
Renovate self hosted using the official Docker image version 15.10

Describe the bug
New versions of gradle plugins are not detected.
The gradle dependencies are working fine though - pull requests for new dependency versions are created as expected.

Did you see anything helpful in debug logs?
No

To Reproduce
A repository with a build.gradle containing a plugins section with old plugin versions:
Example:

plugins {
    id 'org.springframework.boot' version '2.1.1.RELEASE'
    id 'org.sonarqube' version '2.6.2'
}

Expected behavior
Expected new pull requests that changes the versions of gradle plugins.

Screenshots
N/A

[rarkins]

Gradle support is still in beta classification and not enabled by default. Have you explicitly enabled it in your config as per https://github.com/renovatebot/renovate/blob/master/docs/pre-release.md#gradle ?

[rarkins]

BTW if not then you should see a log message like "gradle is disabled" in your logs if you log at debug level

[niclastegner]

I have enabled gradle in the configuration and the "standard" dependencies are handled as expected, also the onboarding pull request worked fine.

[rarkins]

@niclastegner sorry, I misunderstood what you meant. @corecanarias would we expect that plugins are also detected and kept up to date?

[niclastegner]

It looks to me that the inline gradle plugin in lib/manager/gradle/gradle-updates-report.js only support the gradle dependencies.

[jansauer]

Yes; having support for gradle plugins also would be nice and should not be that hard as they are come also from a maven repo.

[corecanarias]

I'll try to take a look because plugins should be dependencies as well, but maybe there is something missing and that's why they are not included in the dependency list.

When I get some time I'll try to get some time to try to parse the build.gradle from renovate so we can have more control on what we process. But I see how this use cases can make it more complicated

[ikesyo]

I'm now tackling this.

[renovate-bot]

:tada: This issue has been resolved in version 19.14.0 :tada:

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot :package::rocket:

[ChristianMurphy]

Testing on https://github.com/Jasig/uPortal

It looks like 19.4.0 brings support for parsing plugins syntax. :+1:
However, it is not looking for Gradle plugins in the Gradle Nexus https://plugins.gradle.org/m2/ :thinking:

 INFO: No versions found for com.github.kt3k.coveralls:com.github.kt3k.coveralls.gradle.plugin in 2 repositories (repository=Jasig/uPortal)
 INFO: Failed to look up dependency com.github.kt3k.coveralls:com.github.kt3k.coveralls.gradle.plugin (repository=Jasig/uPortal, packageFile=build.gradle, dependency=com.github.kt3k.coveralls:com.github.kt3k.coveralls.gradle.plugin)
 INFO: Failed to look up dependency com.github.kt3k.coveralls:com.github.kt3k.coveralls.gradle.plugin (repository=Jasig/uPortal, packageFile=settings.gradle, dependency=com.github.kt3k.coveralls:com.github.kt3k.coveralls.gradle.plugin)
 INFO: Failed to look up dependency com.github.kt3k.coveralls:com.github.kt3k.coveralls.gradle.plugin (repository=Jasig/uPortal, packageFile=uPortal-api/build.gradle, dependency=com.github.kt3k.coveralls:com.github.kt3k.coveralls.gradle.plugin)
 INFO: Failed to look up dependency com.github.kt3k.coveralls:com.github.kt3k.coveralls.gradle.plugin (repository=Jasig/uPortal, packageFile=uPortal-api/uPortal-api-internal/build.gradle, dependency=com.github.kt3k.coveralls:com.github.kt3k.coveralls.gradle.plugin)
 INFO: Failed to look up dependency com.github.kt3k.coveralls:com.github.kt3k.coveralls.gradle.plugin (repository=Jasig/uPortal, packageFile=uPortal-api/uPortal-api-rest/build.gradle, dependency=com.github.kt3k.coveralls:com.github.kt3k.coveralls.gradle.plugin)
 INFO: No versions found for com.github.sherter.google-java-format:com.github.sherter.google-java-format.gradle.plugin in 2 repositories (repository=Jasig/uPortal)
 INFO: Failed to look up dependency com.github.sherter.google-java-format:com.github.sherter.google-java-format.gradle.plugin (repository=Jasig/uPortal, packageFile=build.gradle, dependency=com.github.sherter.google-java-format:com.github.sherter.google-java-format.gradle.plugin)
 INFO: Failed to look up dependency com.github.sherter.google-java-format:com.github.sherter.google-java-format.gradle.plugin (repository=Jasig/uPortal, packageFile=settings.gradle, dependency=com.github.sherter.google-java-format:com.github.sherter.google-java-format.gradle.plugin)
 INFO: Failed to look up dependency com.github.sherter.google-java-format:com.github.sherter.google-java-format.gradle.plugin (repository=Jasig/uPortal, packageFile=uPortal-api/build.gradle, dependency=com.github.sherter.google-java-format:com.github.sherter.google-java-format.gradle.plugin)
 INFO: Failed to look up dependency com.github.sherter.google-java-format:com.github.sherter.google-java-format.gradle.plugin (repository=Jasig/uPortal, packageFile=uPortal-api/uPortal-api-internal/build.gradle, dependency=com.github.sherter.google-java-format:com.github.sherter.google-java-format.gradle.plugin)
 INFO: Failed to look up dependency com.github.sherter.google-java-format:com.github.sherter.google-java-format.gradle.plugin (repository=Jasig/uPortal, packageFile=uPortal-api/uPortal-api-rest/build.gradle, dependency=com.github.sherter.google-java-format:com.github.sherter.google-java-format.gradle.plugin)
 INFO: No versions found for com.moowork.node:com.moowork.node.gradle.plugin in 2 repositories (repository=Jasig/uPortal)
 INFO: Failed to look up dependency com.moowork.node:com.moowork.node.gradle.plugin (repository=Jasig/uPortal, packageFile=build.gradle, dependency=com.moowork.node:com.moowork.node.gradle.plugin)
 INFO: Failed to look up dependency com.moowork.node:com.moowork.node.gradle.plugin (repository=Jasig/uPortal, packageFile=settings.gradle, dependency=com.moowork.node:com.moowork.node.gradle.plugin)
 INFO: Failed to look up dependency com.moowork.node:com.moowork.node.gradle.plugin (repository=Jasig/uPortal, packageFile=uPortal-api/build.gradle, dependency=com.moowork.node:com.moowork.node.gradle.plugin)
 INFO: Failed to look up dependency com.moowork.node:com.moowork.node.gradle.plugin (repository=Jasig/uPortal, packageFile=uPortal-api/uPortal-api-internal/build.gradle, dependency=com.moowork.node:com.moowork.node.gradle.plugin)
 INFO: Failed to look up dependency com.moowork.node:com.moowork.node.gradle.plugin (repository=Jasig/uPortal, packageFile=uPortal-api/uPortal-api-rest/build.gradle, dependency=com.moowork.node:com.moowork.node.gradle.plugin)
 INFO: No versions found for net.researchgate.release:net.researchgate.release.gradle.plugin in 2 repositories (repository=Jasig/uPortal)
 INFO: Failed to look up dependency net.researchgate.release:net.researchgate.release.gradle.plugin (repository=Jasig/uPortal, packageFile=build.gradle, dependency=net.researchgate.release:net.researchgate.release.gradle.plugin)
 INFO: Failed to look up dependency net.researchgate.release:net.researchgate.release.gradle.plugin (repository=Jasig/uPortal, packageFile=settings.gradle, dependency=net.researchgate.release:net.researchgate.release.gradle.plugin)
 INFO: Failed to look up dependency net.researchgate.release:net.researchgate.release.gradle.plugin (repository=Jasig/uPortal, packageFile=uPortal-api/build.gradle, dependency=net.researchgate.release:net.researchgate.release.gradle.plugin)
 INFO: Failed to look up dependency net.researchgate.release:net.researchgate.release.gradle.plugin (repository=Jasig/uPortal, packageFile=uPortal-api/uPortal-api-internal/build.gradle, dependency=net.researchgate.release:net.researchgate.release.gradle.plugin)
 INFO: Failed to look up dependency net.researchgate.release:net.researchgate.release.gradle.plugin (repository=Jasig/uPortal, packageFile=uPortal-api/uPortal-api-rest/build.gradle, dependency=net.researchgate.release:net.researchgate.release.gradle.plugin)
 INFO: No versions found for net.ltgt.errorprone:net.ltgt.errorprone.gradle.plugin in 2 repositories (repository=Jasig/uPortal)
 INFO: Failed to look up dependency net.ltgt.errorprone:net.ltgt.errorprone.gradle.plugin (repository=Jasig/uPortal, packageFile=build.gradle, dependency=net.ltgt.errorprone:net.ltgt.errorprone.gradle.plugin)
 INFO: Failed to look up dependency net.ltgt.errorprone:net.ltgt.errorprone.gradle.plugin (repository=Jasig/uPortal, packageFile=settings.gradle, dependency=net.ltgt.errorprone:net.ltgt.errorprone.gradle.plugin)
 INFO: Failed to look up dependency net.ltgt.errorprone:net.ltgt.errorprone.gradle.plugin (repository=Jasig/uPortal, packageFile=uPortal-api/build.gradle, dependency=net.ltgt.errorprone:net.ltgt.errorprone.gradle.plugin)
 INFO: Failed to look up dependency net.ltgt.errorprone:net.ltgt.errorprone.gradle.plugin (repository=Jasig/uPortal, packageFile=uPortal-api/uPortal-api-internal/build.gradle, dependency=net.ltgt.errorprone:net.ltgt.errorprone.gradle.plugin)
 INFO: Failed to look up dependency net.ltgt.errorprone:net.ltgt.errorprone.gradle.plugin (repository=Jasig/uPortal, packageFile=uPortal-api/uPortal-api-rest/build.gradle, dependency=net.ltgt.errorprone:net.ltgt.errorprone.gradle.plugin)
 INFO: No versions found for nebula.lint:nebula.lint.gradle.plugin in 2 repositories (repository=Jasig/uPortal)
 INFO: Failed to look up dependency nebula.lint:nebula.lint.gradle.plugin (repository=Jasig/uPortal, packageFile=build.gradle, dependency=nebula.lint:nebula.lint.gradle.plugin)
 INFO: Failed to look up dependency nebula.lint:nebula.lint.gradle.plugin (repository=Jasig/uPortal, packageFile=settings.gradle, dependency=nebula.lint:nebula.lint.gradle.plugin)
 INFO: Failed to look up dependency nebula.lint:nebula.lint.gradle.plugin (repository=Jasig/uPortal, packageFile=uPortal-api/build.gradle, dependency=nebula.lint:nebula.lint.gradle.plugin)
 INFO: Failed to look up dependency nebula.lint:nebula.lint.gradle.plugin (repository=Jasig/uPortal, packageFile=uPortal-api/uPortal-api-internal/build.gradle, dependency=nebula.lint:nebula.lint.gradle.plugin)
 INFO: Failed to look up dependency nebula.lint:nebula.lint.gradle.plugin (repository=Jasig/uPortal, packageFile=uPortal-api/uPortal-api-rest/build.gradle, dependency=nebula.lint:nebula.lint.gradle.plugin)
 INFO: No versions found for cz.malohlava.visteg:cz.malohlava.visteg.gradle.plugin in 2 repositories (repository=Jasig/uPortal)
 INFO: Failed to look up dependency cz.malohlava.visteg:cz.malohlava.visteg.gradle.plugin (repository=Jasig/uPortal, packageFile=build.gradle, dependency=cz.malohlava.visteg:cz.malohlava.visteg.gradle.plugin)
 INFO: Failed to look up dependency cz.malohlava.visteg:cz.malohlava.visteg.gradle.plugin (repository=Jasig/uPortal, packageFile=settings.gradle, dependency=cz.malohlava.visteg:cz.malohlava.visteg.gradle.plugin)
 INFO: Failed to look up dependency cz.malohlava.visteg:cz.malohlava.visteg.gradle.plugin (repository=Jasig/uPortal, packageFile=uPortal-api/build.gradle, dependency=cz.malohlava.visteg:cz.malohlava.visteg.gradle.plugin)
 INFO: Failed to look up dependency cz.malohlava.visteg:cz.malohlava.visteg.gradle.plugin (repository=Jasig/uPortal, packageFile=uPortal-api/uPortal-api-internal/build.gradle, dependency=cz.malohlava.visteg:cz.malohlava.visteg.gradle.plugin)
 INFO: Failed to look up dependency cz.malohlava.visteg:cz.malohlava.visteg.gradle.plugin (repository=Jasig/uPortal, packageFile=uPortal-api/uPortal-api-rest/build.gradle, dependency=cz.malohlava.visteg:cz.malohlava.visteg.gradle.plugin)

Are there additional options that need to be set to enable Gradle plugin updates?

[rarkins]

@ChristianMurphy thanks for the feedback. I'm guessing we need to add the plugins.gradle repository to our registryUrls list, and potentially also manipulate the lookupName to match.

[ikesyo]

Thanks for the info! I'll take a look.

[ikesyo]

Submitted the fix for https://github.com/renovatebot/renovate/issues/3534#issuecomment-515116074 -> #4185

[ChristianMurphy]

Thanks @ikesyo! :bowing_man:
That got it working end to end :rocket:

[rarkins]

Nice work, @ikesyo! I'd also welcome a PR adding yourself to the official Renovate contributors list (in package.json) :)

@ChristianMurphy as always, thanks for your great feedback