Refined-github: Display confirmation box when closing an issue with a comment

[Richienb]

Useful to avoid accidentally closing issues.

Should be applied for all issue pages: https://github.com/*/*/issues/*

Should be triggered when clicking this button:

[yakov116]

Don't we already put the close button on the other side to avoid this issue?

[fregante]

Duplicate of https://github.com/sindresorhus/refined-github/issues/1037

Also https://github.com/sindresorhus/refined-github/issues/1598#issuecomment-670928185

[Richienb]

@fregante Sorry for the ambiguity, I actually meant this button:

[fregante]

Sorry I had completely misunderstood. I thought "Closing a tab before submitting a comment"

[fregante]

Should be triggered when clicking this button:

I did this accidentally a few times, but I don't know if I'd find the confirmation less annoying than just reopening the issue 🤔

Don't we already put the close button on the other side to avoid this issue?

Yes: https://github.com/sindresorhus/refined-github/blob/382b398cbaccbb5a3f7135cf873f1302daf5901e/source/features/safer-destructive-actions.css

[Richienb]

Perhaps, instead, there should be a 2-second countdown that allows you to immediately cancel the action.

[fregante]

Given the non-destructiveness of the action I don't think it's worth messing with that. That button already has enough logic behind it (and more is coming with #3881)