Refined-github: `Release-tab` throws an error if `more-dropdown` is turned off

Created on 15 Oct 2020  ·  3Comments  ·  Source: sindresorhus/refined-github

refined-github.js:5841 ❌ Refined GitHub → releases-tab → TypeError: Cannot read property 'before' of null
    at init (refined-github.js:9463)
    at async runFeature (refined-github.js:5881)
    at async setupPageLoad (refined-github.js:5894) 
Search issue: https://github.com/sindresorhus/refined-github/issues?q=is%3Aissue+Cannot%20read%20property%20'before'%20of%20null

Open an issue: https://github.com/sindresorhus/refined-github/issues/new?labels=bug&template=bug_report.md&title=%60releases-tab%60%3A%20Cannot%20read%20property%20'before'%20of%20null
bug

Most helpful comment

I know we discussed in the past that disabling features was kind of at your own risk. If it's an easy fix, let's go for it, otherwise, if you disable one, you disable both. 🤷

All 3 comments

I know we discussed in the past that disabling features was kind of at your own risk. If it's an easy fix, let's go for it, otherwise, if you disable one, you disable both. 🤷

I know we discussed in the past that disabling features was kind of at your own risk. If it's an easy fix, let's go for it, otherwise, if you disable one, you disable both. 🤷

Agree.

However (does not really make a difference) really it goes the other way around more-dropdown is erroring out and then release-tab crashes.

Yeah we generally try not to make the features interdependent simply for maintainability’s sake, but if it’s too hard we just add a comment in refined-github.TS and call it a day.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

shivapoudel picture shivapoudel  ·  3Comments

Arcanemagus picture Arcanemagus  ·  3Comments

MilesBHuff picture MilesBHuff  ·  3Comments

mareksuscak picture mareksuscak  ·  3Comments

supremebeing7 picture supremebeing7  ·  3Comments