Refined-github: `GetCurrentBranch` Stopped working on issues

[yakov116]

This is a major problem

Test on https://github.com/sindresorhus/refined-github/issues/3638 or even this issue.

[fregante]

???

There's no branch on issues.

[fregante]

Also: https://github.com/sindresorhus/refined-github/blob/523f2e3a6d17700f9c45ea474626c647b9617a61/source/github-helpers/index.ts#L20

[yakov116]

But the more-dropdown...

[fregante]

Then the more dropdown… stopped working 😉 not the function itself

[fregante]

We should either ensure that more-dropdown doesn’t call the function where it doesn’t make sense, or that the function returns undefined when it doesn’t find the expected URL format

[notlmn]

I think https://github.com/sindresorhus/refined-github/blob/d7d700a20befb552f9f64e15504b845dbe04e699/source/github-helpers/get-default-branch.ts can be used if getCurrentBranch() fails (combined with returning undefined if it can not find expected URL?

const reference = getCurrentBranch() || getDefaultBranch();

---

OR... should it be the other way, getCurrentBranch() returning getDefaultBranch() as a fallback?

[yakov116]

getCurrentBranch() returning getDefaultBranch() as a fallback?

☝️

[fregante]

I think getCurrentBranch does not make sense outside of code pages, it’s best to make it explicit like in your first example, only where necessary.

[fregante]

On this issue:

$('[type="application/atom+xml"]').href
// -> "https://github.com/sindresorhus/refined-github/commits/master.atom"

So what's the error? It exists and it's already the default branch

[yakov116]

$('[type="application/atom+xml"]').href
// Uncaught TypeError: Cannot read property 'href' of null

not for me

[notlmn]

$('[type="application/atom+xml"]').href
// Uncaught TypeError: $(...) is null

Me neither (on Firefox)

[fregante]

I think I encountered the same issue that caused https://github.com/sindresorhus/refined-github/issues/2799 (i.e. GitHub doesn't cleanup the links after AJAX navigation)

[yakov116]

I think we should send a ticket into github. We really depend on it, (the whole GithubURL will not work). I hope they are not removing it.

[fregante]

This is not a bug. Issues don’t have a branch.

GitHubURL should not depend on it.