Refined-github: Options page in Edge Chromium has fixed width

Created on 3 Jul 2020  路  5Comments  路  Source: sindresorhus/refined-github

Not really a bug, but I would like to open it here to track the issue.

This is how options page looks in Edge Chromium (85.0.552.1, Windows 10):

image

The width is defined by the following line, which is initially added by #934:

https://github.com/sindresorhus/refined-github/blob/4e0245d3faf0518e3e22358cdc5315e4e0c2f13c/source/options.css#L3

It seems Edge has a fixed width for options popup and won't adjust it responsively:

image

bug good first issue help wanted

All 5 comments

I think we went back and forth on this. It鈥檚 worth looking at the History of the file to see why it鈥檚 there in the first place.

Should it be dropped?
Should it be reduced to 400px?
Should we exclude Edge from this width with @media not screen and (width:400px) {}?

History: 400px (#934) -> 430px (#1193) -> 550px (#1780)

Should it be dropped?

I tried to remove it in Chrome and it looks fine (at first view).

Should it be reduced to 400px?
Should we exclude Edge from this width with @media not screen and (width:400px) {}?

I think either would be fine.

I prefer this if it works:

@media not screen and (width:400px) { /* Excludes Edge */
    :root {
        min-width: 550px;
    }
}

It works in both Edge and Chrome 馃槃

Threw it into #3314

Was this page helpful?
0 / 5 - 0 ratings

Related issues

hkdobrev picture hkdobrev  路  3Comments

vanniktech picture vanniktech  路  3Comments

mareksuscak picture mareksuscak  路  3Comments

Celthi picture Celthi  路  3Comments

sompylasar picture sompylasar  路  3Comments