Refined-github: `GitHubURL`: 'pathname' called on an object that does not implement interface URL

[FloEdelmann]

This line causes the error in Firefox 77:

https://github.com/sindresorhus/refined-github/blob/8b135715bbd73609a67ffd3ab104b1dbbe39edc1/source/github-helpers/github-url.ts#L19

It appears to happen only for some links, not all. It doesn't matter whether I have the "Repository refresh" beta enabled or disabled. Places where I have spotted it:

edit-files-faster

https://github.com/sindresorhus/refined-github/blob/8b135715bbd73609a67ffd3ab104b1dbbe39edc1/source/features/edit-files-faster.tsx#L17

Sometimes only the last link or even more links are affected, but they seem to always keep working up to some point.

edit-readme

https://github.com/sindresorhus/refined-github/blob/8b135715bbd73609a67ffd3ab104b1dbbe39edc1/source/features/edit-readme.tsx#L20

Sometimes it works just fine, sometimes it errors (in the same repo).

latest-tag-button

https://github.com/sindresorhus/refined-github/blob/8b135715bbd73609a67ffd3ab104b1dbbe39edc1/source/features/latest-tag-button.tsx#L97

Sometimes it works just fine, sometimes it errors (in the same repo).

[yakov116]

Whats the error?

[FloEdelmann]

As the title says, 'pathname' called on an object that does not implement interface URL.

[yakov116]

As the title says, 'pathname' called on an object that does not implement interface URL.

I saw that I was asking for the stack-trace. (Sorry for not being clear)

I did some debugging it is edit-files-faster. Disable that and everything works fine. I cant see why everything looks ok.

[FloEdelmann]

The stacktrace looks like this:

20:53:46.200 ❌ Refined GitHub → edit-files-faster → TypeError: "'pathname' called on an object that does not implement interface URL."
    github_url_GitHubURL moz-extension://2b7c51a0-9289-43d1-ae10-396bc8aa59bc/refined-github.js:4671
    edit_files_faster_init moz-extension://2b7c51a0-9289-43d1-ae10-396bc8aa59bc/refined-github.js:6469
    runFeature moz-extension://2b7c51a0-9289-43d1-ae10-396bc8aa59bc/refined-github.js:2832
    setupPageLoad moz-extension://2b7c51a0-9289-43d1-ae10-396bc8aa59bc/refined-github.js:2840
    add moz-extension://2b7c51a0-9289-43d1-ae10-396bc8aa59bc/refined-github.js:2874

[fregante]

The error is really weird and there's not much literature about it online. Are you sure there aren't other extensions running? Perhaps you'll have to open the debugger and make it stop on error. That way you can see exactly what’s happening (you might have to disable sourcemaps)

[yakov116]

I have the error too (only firefox). Really weird

I did some debugging it is edit-files-faster. Disable that and everything works fine. I cant see why everything looks ok.

What even more weird is I could not get it to error on any other repo besides RG

[FloEdelmann]

What even more weird is I could not get it to error on any other repo besides RG

It fails consistently for me here: https://github.com/OpenLightingProject/open-fixture-library

Are you sure there aren't other extensions running?

yes

Perhaps you'll have to open the debugger and make it stop on error. That way you can see exactly what’s happening

I just tried that, but it doesn't help me find the cause.

[yakov116]

What even more weird is I could not get it to error on any other repo besides RG

It fails consistently for me here: OpenLightingProject/open-fixture-library

Thanks

Can you try to disable edit-files-fasterand see if it does not error? By me it does not.
(Just want to make sure were seeing the same thing)

[yakov116]

Wacky!! If there is a file that has the words config.json it errors

https://github.com/yakov116/TestR

[FloEdelmann]

I've just seen that (at least) in Firefox 77, the assign calls also don't work, so all the URL manipulations don't do anything, breaking most features using GithubURL.