Refined-github: Add `dim-merge-commits` feature

Created on 23 Feb 2020  路  8Comments  路  Source: sindresorhus/refined-github

This would solve the "noise" concern mentioned in #2768

It would have to use a combined GraphQL query to determine which commits on the current page are merge commits, and then just apply opacity: 0.6 on their whole line. Or something like that.

"Combined GraphQL query" example: https://github.com/sindresorhus/refined-github/pull/2795/files#diff-04c19a6c246911e079b45f999eab501cR14-R22

Test URL

https://github.com/babel/babel/commits/master?after=ddd40bf5c7ad8565fc990f26142f85613958a329+104

_Originally posted by @fregante in https://github.com/sindresorhus/refined-github/issues/2768#issuecomment-590036267_

enhancement good first issue help wanted

All 8 comments

@sindresorhus we only dropped it, since github removed the class to be able to check that it was there.

@sindresorhus exactly! Except now it requires an API request for every isCommitList page load

@fregante wouldn't it be the same as add-tags-to-comits

I started looking into the code and then I realized your going to want to save each commit to storage.

Just curious are we not already that we can use it for both things?

That feature is too complex and I don鈥檛 want a copy of it. If anything we should drop/simplify the caching from it.

@fregante do you have any idea how we can figure out if its a merge commit. I tried all ways I cant figure out a normal way.

I think only merge commits have 2 parent commits

@fregante Im working on it

Was this page helpful?
0 / 5 - 0 ratings