Refined-github: Restore `quick-review-button` feature

[avaly]

I can not approve/request changes/comment on any pull request.

The behavior works if I disable the add-on.

Browser: Firefox 72.0.1
Add-on version: 20.1.14

[mauriciord]

Browser: Firefox Developer Edition 73.0b4 (64-bit)
Add-on version: 20.1.14

[dsiebel]

Same here, looks like the quick-review-button feature is having issues. I disabled it and the "old" buttons are working.

Browser: Firefox Developer Edition 73.0b4 (64-bit)
Add-on version: 20.1.14

[fregante]

I just pushed a hotfix. Chrome isn't affected because 20.1.14 was rejected.

Try updating soon, you should see 20.1.14.1820

[dsiebel]

Thanks for the quick reaction!
I am on 20.1.14.1820 now, but I can not re-enable the feature.
It says its "Disabled because of #2700" and I can not tick the box:

(or was the hotfix to disable it?)

[yakov116]

@dsiebel hot fix was to disable

[fregante]

I think this bug is due to https://github.com/sindresorhus/refined-github/pull/2639

I haven’t had time to investigate so I just disabled the feature since it broke GitHub.

[fregante]

It was actually https://github.com/sindresorhus/refined-github/commit/4c502f50b45d339f9eb6fb3964b4eabc7ba7a36f

It forced me to add a type=button attribute on buttons, which removes the default submit behavior; in 2 cases, the button actually had to submit.

[mobilutz]

It was actually 4c502f5

It forced me to add a type=button attribute on buttons, which removes the default submit behavior; in 2 cases, the button actually had to submit.

@fregante Did you look into configuration the button-has-type eslint plugin?
https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/button-has-type.md