Refined-github: Reposition `tag-changelog-link`

Created on 13 Jan 2020  Ā·  9Comments  Ā·  Source: sindresorhus/refined-github

GitHub implemented a more generic (i.e. less efficient) version of tag-changelog-link

Their feature is not a strict replacement, but now tag-changelog-link needs to be moved above it (or... alternative solutions welcome)

Test

https://github.com/sindresorhus/refined-github/releases/tag/20.1.6

enhancement good first issue help wanted

Most helpful comment

@fregante #2686

All 9 comments

I won't change it. This feature is visually loaded late, introducing an jump in UI if it were placed before the dropdown. Or we need to reserve the place immediately with some CSS.

introducing an jump in UI if it were placed before the dropdown

True.

Or we need to reserve the place immediately with some CSS

That may be possible and wouldn't look terrible.

Alternatively we can reposition _their_ button elsewhere

I'm kinda disappointed that they just put the button there. Now we have 3 "compare" links on the page.

@fregante #2686

Now we have 3 "compare" links on the page.

Noted! We might combine them in a future iteration – but there aren't any plans to _as of right now_.

GitHub implemented a more generic (i.e. less efficient) version of tag-changelog-link

A little background here if it helps– we originally spiked out a version that was almost identical to the refined-github version. But when we tested it with some organisations who run different 'release channels/lines' at a time – it actually made things more confusing for their users. So this was a way to mitigate and make comparing release more 'self serve'.

Ideally, I'd love to see us have better support all-round for different Release workflows (hence my tweet) and it's something I'll be advocating for internally šŸ˜„.

Yeah I figured that you can’t make a solution that makes everyone happy. Extensions have the privilege of making feature that only work for a subset of users.

For Refined GitHub: we could also combine this to:


Compare to: master (+7) | previous tag | tag...


However I do like the current ā€œChangelogā€ label.

However I do like the current ā€œChangelogā€ label.

For this reason, I suggest we just move our Changelog link above the "Compare" dropdown, that's all.

Wait, I thought GitHub was adding this link on releases all along. Damn!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

durka picture durka  Ā·  3Comments

alexanderadam picture alexanderadam  Ā·  3Comments

fregante picture fregante  Ā·  3Comments

Celthi picture Celthi  Ā·  3Comments

hkdobrev picture hkdobrev  Ā·  3Comments