Refined-github: Change button colour background to the `Draft` PR label

Created on 20 Sep 2019  路  13Comments  路  Source: sindresorhus/refined-github

It's nice to have "labels" on our pull requests, though with a Draft pull request this isn't always practical, though when you view a list of PRs the Draft PR label/status is easily missed, adding a light grey background colour to the Draft text would help make these stand out a little clearer IMHO.

Example URL: https://github.com/WordPress/gutenberg/pulls
Screen Shot 2019-09-20 at 12 47 58 pm

change request under discussion

Most helpful comment

I name this feature emphasize-draft-pr-label , aimed at making that label stand out

I don't think draft PRs should stand out, but the opposite, like you said next:

the color 'gray' itself says "Oh oh don't pay too much attention to me"

The gray does that, but the size doesn't; the visual weight is higher.

I'd go as far as dimming the whole line instead.

Regular

gray icon

Now

gray background

Suggested

Opacity 0.7

dimmed line

All 13 comments

Screenshot 2019-09-20 at 10 31 05

Like this?

/* demo */
span[aria-label="Open draft pull request"] {
    background: #e8e8e8;
    width: 1.6em;
    display: inline-flex;
    height: 1.6em;
    align-items: center;
    justify-content: center;
    border-radius: 50%;
    margin: -1em;
    margin-left: -0.4em;
    margin-right: -0.2em;
}
span[aria-label="Open draft pull request"] svg {
    color: white !important;
}

Yeah, something like that would be great:)

I would make the actual icon slightly darker gray than white, as now, the icon it almost not visible.

Do you mean the regular icon but darker? Or my circle + dark gray icon instead of white?

I'd do the circle darker gray. It seems from the screenshots that the circle is lighter than the original icon?

This should be an easy CSS-only solution. PR and design suggestion/mockups welcome

I've made the badge color a little darker.
emphasize-draft-pr-label

I鈥檓 not sure I like it this dark. I preferred it to be less visible, not more

I agree. WIP-PR's feel more visible and stressed than a normal, ready for review or waiting for merge PR now.

I name this feature emphasize-draft-pr-label , aimed at making that label stand out. Felt that level of gray - IMHO the color 'gray' itself says "Oh oh don't pay too much attention to me"- is fine to me.
But yes, reviews and PRs are welcome.

I name this feature emphasize-draft-pr-label , aimed at making that label stand out

I don't think draft PRs should stand out, but the opposite, like you said next:

the color 'gray' itself says "Oh oh don't pay too much attention to me"

The gray does that, but the size doesn't; the visual weight is higher.

I'd go as far as dimming the whole line instead.

Regular

gray icon

Now

gray background

Suggested

Opacity 0.7

dimmed line

@fregante thanks for taking care. It looks good :)

Now that I use it, I realize that - unlike your suggestion here - you only changed the PR icon and did not use grey text on the PR titel as well.
Was that on purpose? I liked that a lot, to emphasize the titel of draft pr's less too.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

shivapoudel picture shivapoudel  路  3Comments

hkdobrev picture hkdobrev  路  3Comments

fregante picture fregante  路  3Comments

supremebeing7 picture supremebeing7  路  3Comments

sompylasar picture sompylasar  路  3Comments