Refined-github: Add `show-whitespace` toggle button

[jerone]

I like the new show-whitespaces feature. But it's enabled by default, with no easy way to toggle it on or off.

What if we add a toggle button (just like the ?w=1 toggle).

Maybe unchecked by default.

See https://github.com/sindresorhus/refined-github/pull/2073#issuecomment-511251314.

---

IssueHunt Summary

Backers (Total: $0.00)

Become a backer now!

Or submit a pull request to get the deposits!

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
  

  - Need some help from other developers? Add your repositories on IssueHunt to raise funds.

IssueHunt has been backed by the following sponsors. Become a sponsor

[Vannevelj]

Just to give my two cents: this is very noisy for me and is the sort of feature that would make me consider removing the extension if it stays enabled for too long.

[jerone]

@Vannevelj commented on Jul 16, 2019, 10:50 AM GMT+2:

Just to give my two cents: this is very noisy for me and is the sort of feature that would make me consider removing the extension if it stays enabled for too long.

You can always go to Refined GitHub options and disable show-whitespace feature:

No need to completely remove this extension.

[Vannevelj]

@jerone Awesome, I wasn't aware there was an options section. So far the default changes have always been perfect for me and I never had the need to configure anything. Much appreciated, thanks.

[ndbeals]

@jerone Apparently I am blind and cannot find those settings for the life of me. this is not because A lack of trying, Where can I find them?

[yakov116]

[ndbeals]

Yeah I literally just figured that out myself and was coming back to update my comment, Appreciate it.

IDK how I missed it. Thanks.

[notlmn]

Extended description here: https://github.com/sindresorhus/refined-github/pull/2073#issuecomment-512070277.

Meanwhile if any of you don't like this feature, just disable the feature, or try to see if you can disable features before starting to complain.

Thanks.

[fregante]

the sort of feature that would make me consider removing the extension if it stays enabled for too long

Anyone who wants to remove the extension can remove it. It's free, having it installed only improves _your_ experience, no one else benefits from it.

---

There are two ways to improve this situation:

• add a toggle (ideal) https://github.com/sindresorhus/refined-github/pull/2073#issuecomment-512140251
• make the feature _disabled by default_ (suggested by Sindre as a generic alternative to possibly controversial features, but I'm still not a fan of this method)

[jerone]

What if we add a toggle button (just like the ?w=1 toggle).

I made an POC by adding an toggle button to the blob, compare and commit page.

Screenshots

Screenshot blob page

Screenshot commit page

Screenshot compare page

But I'm not sure what to do with the remaining pages:

• PR files
• PR feedback
• PR suggestions
• inline code
• others...

Looking for suggestions 👀

[fregante]

Honestly I don’t see the value in this. I never disable whitespace in my editor so why would anyone need to do it here?

Most people had a knee-jerk reaction when the feature was added but this isn’t a solution to that. Those who don’t like the feature can just disable (or already have), we already have options for this.

Adding a distracting toggle for this seems futile. I’d close this issue

[fregante]

@jerone thank you for contributing with IssueHunt. I think you can pull your donation from this issue

[issuehunt-app[bot]]

@sindresorhus has cancelled @jerone's funding for this issue.(Cancelled amount: $10.00) See it on IssueHunt