Refined-github: Drop `upload-button` feature

[fregante]

The feature is currently broken. It was initially added because we hide this bar via CSS:

However now we have two reasons why this is not useful:

• upload-button now also takes care of hiding the bar; i.e. the feature can be disabled altogether and the bar reappears
• we now also offer a CSS field to restore the bar

Additionally:

• We have a related feature that drops the Upload files button from file lists and does not add an alternative. Likewise, people can just upload files via drag-drop or disable the feature.

Therefore we can either:

• 👎 Keep the feature as JS, but not add the alternative button
• 👍 Drop the JS feature and just hide the bar via CSS (who doesn't want it can undo it easily in the custom CSS field)

[Mange]

who doesn't want it can undo it easily in the custom CSS field

How can I undo this? I cannot use drag-and-drop so I need to be able to click this button to get a file selector up and it's not clear to me what I can do to get it back.

[fregante]

Probably

.drag-and-drop {
    display: block !important;
}

[Mange]

I finally got it working with

/* Restore upload message on comment box */
body file-attachment.is-default .drag-and-drop {
    display: flex !important;
}

I had to add body to add extra specificity since the stylesheet overrides in the settings are loaded before the stylesheet, so it didn't win the specificity war.

[fregante]

!important doesn’t care about specificity, the last important wins 😅

[Mange]

I'm pretty sure it still counts, it's just that it's sorted "important,
specificity". So important always wins over non-important, but among
important the specificity still wins.

I'm not sure how else the trick would have fixed it.

Den lör 1 juni 2019 04:52Federico Brigante [e-mail] skrev:

!important doesn’t care about specificity, the last important wins 😅

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/sindresorhus/refined-github/issues/2014?email_source=notifications&email_token=AAAAMPYUU6YP2BPMN5NYFU3PYHP6NA5CNFSM4HK6VPO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWWXGEA#issuecomment-497906448,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAAMPZN465S3STRCTDR7ELPYHP6NANCNFSM4HK6VPOQ
.

[Mange]

An update for any future searchonauts:

Since #2086, you need to use this override in the CSS:

/* Restore upload message on comment box */
body file-attachment.js-upload-markdown-image.is-default .drag-and-drop {
    display: flex !important;
}

[ShalokShalom]

Can we add an option for this?

[fabiospampinato]

Shouldn't the currently hidden bar for uploading a file be re-enabled then?

Basically forcing users to always use drag & drop provides no advantage whatsoever to me.

[fregante]

The option is the CSS

[fregante]

https://github.com/sindresorhus/refined-github/issues/2155