Refined-github: show-names no longer shows names

[dotconnor]

Names no longer show up next to a person's username on discussions.
Disabled:

Enabled:

Expected:

[hardikmodha]

@dotconnor It requires the personal authentication token. You can generate one from here and add it from extension options.

[Phrynobatrachus]

I have a token and it is still broken at the moment. I'm looking into it.

[dotconnor]

@HardikModha I have a token set, I even confirm it by creating a new token with all permissions; I can also see the network request made for the feature and it does, in fact, return the correct data.

[hardikmodha]

@dotconnor @Phrynobatrachus I've debugged the issue.

1.

<span className="css-truncate-target" style={{maxWidth: '200px'}}>
    {name} // This should be `names[userKey].name`
</span>

1. Even after replacing {name} with the names[userKey].name it is broken.

For the currently logged in user, the name is not present in the names array returned from the API. That's where it is breaking. You can test it by visiting an issue which is not created by you and you'll see the names.

[Phrynobatrachus]

Yeah I have it working locally. I'm not sure how it was working before with the {name} interpolation since that's not defined from what I see? I also don't know why your own username wasn't included before, I'm just adding it to the set after the getUsername() and it seems to work ok.

[fregante]

This was likely broken by some of my changes in #1783, you can see how it was before that PR: https://github.com/sindresorhus/refined-github/tree/5d66c95516e6f5f4ea4943acbe96c168be517910