Refined-github: Show warning if PR submitter tries to uncheck `Allow edits from maintainers`

Created on 12 Dec 2018  路  7Comments  路  Source: sindresorhus/refined-github

I often get PRs where the user has unchecked Allow edits from maintainers. when creating a PR. This is super annoying as it means I cannot easily do changes to the PR myself. There's no reason for users to do this. Would be nice to show a warning if a user tries to uncheck it that explains why unchecking it would be annoying to the maintainers.

screen shot 2018-12-12 at 21 19 07

enhancement good first issue help wanted

All 7 comments

_For anyone that wants this, please also send this feature request to GitHub: [email protected]_

This should be easy to implement via CSS :checked + span selector and content CSS property. PR welcome

Edit: not possible. There are no elements after :checked to attach content. This needs to be a JS feature

@bfred-it I'd like to give this issue a go if no one is working on it yet.

Go ahead!

@bfred-it since there is no element to attach a warning message to, could triggering the pop-up from the learn more button work as a solution? (with maybe a modified message)

screenshot 2019-02-11 at 12 45 42 pm

It needs to be a visible warning. The style and code should probably be similar to this:

https://github.com/sindresorhus/refined-github/pull/1758#issuecomment-462204170

It needs to be a visible warning. The style and code should probably be similar to this:

#1758 (comment)

Thanks @bfred-it , that's exactly what I needed. I am open to suggestions on the final wording that could be used, but this is what I have so far.

screenshot 2019-02-11 at 3 22 26 pm

Was this page helpful?
0 / 5 - 0 ratings