As the issue title says, notifications that are manually "Marked as Unread" gets removed when pressing "Mark all {repository} notifications as read" in another (unrelated) repository.
To reproduce:
Urelated (in another repo) notifications should not be affected
Browser: Chrome, Version 70.0.3538.102
Refined Github Extension: Version 18.11.21.1745
Can verify that this is a bug from the RGH side, and the culprit being these lines https://github.com/sindresorhus/refined-github/blob/561af934726cf981743a53417051b306f920cb06/source/features/mark-unread.js#L370-L372
The above lines remove all marked-as-unread-notifications, regardless of the notifications it was supposed to clear. The above code should been something like
delegate('form[action="/notifications/mark"] button', 'click', ({delegateTarget}) => {
const group = delegateTarget.closest('.boxed-group');
const repo = select('.notifications-repo-link', group).textContent;
storage.set(storage.get().filter(notif => notif.repository != repo));
})
Most helpful comment
Can verify that this is a bug from the RGH side, and the culprit being these lines https://github.com/sindresorhus/refined-github/blob/561af934726cf981743a53417051b306f920cb06/source/features/mark-unread.js#L370-L372
The above lines remove all marked-as-unread-notifications, regardless of the notifications it was supposed to clear. The above code should been something like