Refined-github: More friendly "Changes requested" state in PRs

[sindresorhus]

See: https://twitter.com/ashfurrow/status/1056944193669599233

We could change the color and icon to something more friendly, while still keeping it obvious that it's not approved.

[ashfurrow]

My personal favourite approach would be an orange “pending” badge, like when CI is still running. That conveys the “request changes” idea far more accurately than a red x, which is more “reject changes” imo.

[xavhan]

What about somekind of a turning back arrow suggesting the idea of a feedback instead of a refusal?

[pqt]

Could use the diff octicon?

https://octicons.github.com/icon/diff/

[manojchandrashekar]

Not sure if it can be implemented, but I like the idea of specifying if the "changes requested" was in fact,

• just feedback
• good-to-have, or
• must-have

Anyway, it would be great to have the icon changed to a yellow alert ⚠ at least.

[fregante]

They did it. The color is still red, but it's no longer a ❌

https://twitter.com/natfriedman/status/1084888939112980480

[sindresorhus]

I think we should still change the color.

[vanniktech]

How about orange?

[connorbrathwaite]

I think we should still change the color.

for (const reviewChangesSvg of select.all('.octicon-request-changes')) {
  reviewChangesSvg.classList.remove('text-red');
  reviewChangesSvg.classList.add('text-pending');
}

where

.text-pending {
  color: #b08800!important;
}

->

?

[sindresorhus]

The red circle and text too.

[nesl247]

I would not use the pending color IMO. It blends in too much with the icon on the left, and also blends in too much with other status checks that are in progress.

I'm in favor of keeping it as it is, as the red actually makes it stand out that changes are requested, and it's a blocker for the PR to be merged. Any blockers on a PR are red, therefore it makes sense to keep the color the same IMO.

[fregante]

I would not use the pending color IMO

👍

Official colors to chose from: https://primer.style/css/support/color-system

Also this feature should be CSS-only, it's just easier in every way.