Refined-github: Shortcut for approving merged pull requests

Created on 9 Aug 2018  路  4Comments  路  Source: sindresorhus/refined-github

Often times I'm still reviewing pull requests that have been merged already. It would be nice if there would an approve button.

Currently it looks like this:

screenshot from 2018-08-09 14-07-25

Maybe a button next to Submit review that is called Approve and when clicked will insert :+1: into the textfield and hit on the submit review button.

Most helpful comment

Two issues with this:

  • approvals after a merge mean nothing, so if you鈥檙e still reviewing you鈥檒l just have to send it as comment, if you have anything to say
  • 馃憤 might not be what people want to say, and we can鈥檛 have an option to customize this shortcut

All 4 comments

@vanniktech you cant, once its merged you cant approve anymore

Yes. But you can workaround that by inserting :+1: and clicking on submit review.

Two issues with this:

  • approvals after a merge mean nothing, so if you鈥檙e still reviewing you鈥檒l just have to send it as comment, if you have anything to say
  • 馃憤 might not be what people want to say, and we can鈥檛 have an option to customize this shortcut

Thanks for the suggestion, but we're going to pass on this :)

Was this page helpful?
0 / 5 - 0 ratings