Refined-github: PR suggestion box overlays extra extensions' content

Created on 20 Jul 2018  ·  7Comments  ·  Source: sindresorhus/refined-github

Fun combination with SourceGraph. @sqs

image

Adding this CSS rule on top of the existing ones fixes it:

[data-url$="recently_touched_branches_list"] {
    background: transparent;
}

image

bug good first issue help wanted

Most helpful comment

Thanks! We will test and submit a PR to this repository. Many of us use Refined GitHub here @sourcegraph and should have fixed this sooner! 😃

All 7 comments

Thanks! We will test and submit a PR to this repository. Many of us use Refined GitHub here @sourcegraph and should have fixed this sooner! 😃

Essentially a known issue tracked in https://github.com/sindresorhus/refined-github/issues/1109

It would be nice to move it here:

PRs welcome 😍

@bfred-it that issue has been open since February and hasn't seen activity since March. Can we keep this open as a non-duplicate workaround until the dialog is moved?

I don't see any reason not to fix this small issue in the meantime.

The issue remains here for those who look for it. No reason to keep two issues open about the same thing.

I don't see any reason not to fix this small issue in the meantime.

PR welcome to drop the background color and this line. It was added to cover all the buttons but I can't find the discussion about it anywhere, so maybe it's fine.

Anyway, reopening the issue for someone to close it via PR soon 😁

@JoshuaKGoldberg will you send a PR or can this be closed?

Just submitted a PR https://github.com/sindresorhus/refined-github/pull/1513 to fix this. (Sorry for losing track of it!)

Thanks! We might as well push it down of about 25px to only overlap the buttons partially. Perfect alignment isn’t possible because the distance also depends on the possible “Forked from xxx/xxx” text. The gray background masked this issue before.

Was this page helpful?
0 / 5 - 0 ratings