Refined-github: Show issue resolution in header (was it closed by a PR?)

[fregante]

Visit this issue: https://github.com/sindresorhus/refined-github/issues/80

Can you tell whether it was accepted? How about visiting what closed it?

How about this?

This should be an easy fix since the PR ID is at the bottom of the page. The ID would be clickable.

[yakov116]

How would you do it if it was a commit that closed it?

[fregante]

Same, plus <code>

Testing thread: https://github.com/bfred-it/github-issue-link-status/issues/2

---

I think the question would be: what if it's closed, reopened, then closed again?

Example:

https://github.com/sindresorhus/refined-github/issues/479 (closed by pr, then closed manually)
https://github.com/sindresorhus/refined-github/issues/565 (closed by a commit, then by a pr)

[yakov116]

I would do "via" instead of "by" for a commit and make the color different (purple is usually for merged)

[sindresorhus]

Yes! I can't believe GitHub doesn't do this. I'm gonna send a feature request to GitHub too (please do so too), although I doubt they'll do this.

[fregante]

Color: well, yeah, merged PRs are purple and they mean "accepted". In this case the issue would be "closed positively", and generally "closed by a merged pr"

Wording: GitHub uses user closed this in #1, so maybe we should match in

Additionally: the whole label could link to the event in the timeline, while the PR/commit would link directly there (nested <a>s, yes. Both browsers support them)

[jgierer12]

I think the question would be: what if it's closed, reopened, then closed again?

I'd always take the most recent action, i.e.

479 => Red, 'Closed'

565 => Purple, 'Closed in #804'

Purple + 'in' is best for commits too IMO since it's what GitHub uses for both PRs and commits.

the whole label could link to the event in the timeline

👍, same for red 'Closed'

[hkdobrev]

I'd prefer to always keep the red closed label as it is, but add the link to the PR with purple and a tooltip for the title next to it. Due to habit and separation of the statuses. Sometimes an issue is closed because a PR closes it without the actual issue implemented as originally reported/requested. We could even mimic the chronology style GitHub does (it's just at the top and end of the page):

mojavelinux opened this issue on 14 Mar 2016

bfred-it closed this in #935 20 hours ago

[fregante]

without the actual issue implemented as originally reported/requested

Is that relevant though? If a PR closes an issue, it essentially marks it as _resolved_, as intended by the maintainer. The purple just matches the closing PR's color and that's what we're highlighting.

Even purple PRs sometimes don't do what their intention was, or are undone later, so the only purpose that the color has is to mark a PR as merged, or in this case an issue closed by a successfully merged PR.

We could even mimic the chronology style GitHub does

I don't think that it adds anything more to the suggested mockup.