Refined-github: Some features use underscores for feature disabling

Created on 28 Dec 2017  路  7Comments  路  Source: sindresorhus/refined-github

I tried disabling some features (btw great feature! pun intended), but some weren't working for me. When turning on the debug log I found that the one I wanted to disable was using underscores instead of dashes: linkify_branch_refs. Neither the overview (https://github.com/sindresorhus/refined-github/tree/master/source/features) nor the file (https://github.com/sindresorhus/refined-github/blob/master/source/features/linkify-branch-refs.js) reveal that.

It would be great if this (seems like an edge case) is fixed, or it becomes more discoverable.

bug

Most helpful comment

I wonder now why you were trying to disable linkify_branch_refs

All 7 comments

Thanks for the fix and the migration!

I wonder now why you were trying to disable linkify_branch_refs

Because I usually double click the branch name on top of a PR to copy it to a CLI. I almost never go to the branch itself, so the link is also not that useful to me.

Maybe a copy button next to them would be helpful to support both cases.

Because I usually double click the branch name on top of a PR to copy it to a CLI. I almost never go to the branch itself, so the link is also not that useful to me.

Maybe a copy button next to them would be helpful to support both cases.

BTW related discussions were held in #77 and #78.

For reference, you can also select text in link with by holding alt (at least on Chrome/macOS)

Ha thanks for the links to the long discussions :) For my and my teams workflow it is very useful to have the branch name. But it's okay. I'm very happy being able to disable the linkify as I never visit those links anyway.

The alt is working for me too, although a bit buggy. I'll see if I can get it into my workflow.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

supremebeing7 picture supremebeing7  路  3Comments

juliocanares picture juliocanares  路  3Comments

alexanderadam picture alexanderadam  路  3Comments

yakov116 picture yakov116  路  3Comments

Arcanemagus picture Arcanemagus  路  3Comments