Refined-github: Image Upload button not working

Created on 26 Oct 2017  路  1Comment  路  Source: sindresorhus/refined-github

The image upload button stopped working for replies, comments, issues, etc.

I believe the culprit is that it is not a button but a label element. Seems like this is a mistake and that a click handler is likely missing/not working because of it.

Here is an image of the button I'm referring to:
screen shot 2017-10-26 at 9 34 44 am

And here is an image of the markup I'm seeing when I inspect it:
screen shot 2017-10-26 at 9 37 54 am

bug

Most helpful comment

What a coincidence, I fixed it 4 hours ago, but the PR hasn't been merged yet 馃槅

The <label> was supposed to be linked to the <input type="file"> field but I guess the selector was modified and jQuery swallowed the error.

>All comments

What a coincidence, I fixed it 4 hours ago, but the PR hasn't been merged yet 馃槅

The <label> was supposed to be linked to the <input type="file"> field but I guess the selector was modified and jQuery swallowed the error.

Was this page helpful?
0 / 5 - 0 ratings