Refined-github: Stylize OP name in comments

Created on 6 Mar 2017  路  15Comments  路  Source: sindresorhus/refined-github

Similar to how StackOverflow does it, can the OP name be stylized slightly differently when adding a comment to issues and pull requests?

enhancement good first issue help wanted

Most helpful comment

I really like the badges from GitHub saying "Owner", "Collaborator", "Contributor". Do you think we could another one next to it saying "OP" or something like that?

This idea is most aligned with GH's styling. Also, it's more accessible than a colored BG or something, which might be hard to see/notice for some users.

All 15 comments

Any suggestion on what kind of styling?

Something simple, like a background color?

If you look at any question on StackOverflow, you can see how the OP's name is displayed with a light blue background, including in any comments on the page, and also if the OP provides an answer.

Made a couple of mockups:

  • Gray border (matching the Owner/Contributor tags)
    1

  • GitHub's normal link color
    2

  • Light gray background, the same gray as the border above
    3

// @schmuli @sindresorhus

Actually, I just noticed that when viewing your own comments, GitHub will add a slight blue background color to the whole comment header. Maybe something along those lines?

Otherwise, @jacobbearden mockups are great too, and also reuse existing GitHub styles/colors. I would probably go with the light gray background (3rd option).

I really like the badges from GitHub saying "Owner", "Collaborator", "Contributor". Do you think we could another one next to it saying "OP" or something like that?

P.S. Actually all three are in this thread at the moment! 馃槅

I really like the badges from GitHub saying "Owner", "Collaborator", "Contributor". Do you think we could another one next to it saying "OP" or something like that?

This idea is most aligned with GH's styling. Also, it's more accessible than a colored BG or something, which might be hard to see/notice for some users.

It's also more explicit as some people might not be aware what the colouring is for.

The thing about using the badge is that the User may have their own "Owner"/"Collaborator"/etc. badge, and adding another badge might not be so clean.

Additionally, this feature will be included in the README of the extension, so anyone can find out about it and what decoration it will use. Personally, I don't like the abbreviation "OP", especially as a badge in this case.

The thing about using the badge is that the User may have their own "Owner"/"Collaborator"/etc. badge, and adding another badge might not be so clean.

They'd have to stack to the left. I'm not sure this is a major detraction.

(I used @hkdobrev here only because he had the "Collaborator" badge already.)
screen shot 2017-03-08 at 10 00 15 am

Additionally, this feature will be included in the README of the extension, so anyone can find out about it and what decoration it will use.

LOL, I'm not sure I've read the whole README on this project. :rofl:

Personally, I don't like the abbreviation "OP", especially as a badge in this case.

"OP" might not be the best choice, I agree. What about "Original Poster"?

BTW, there is another project that is more robust, but doesn't "follow" the poster through all comments in a thread. Check out: https://github.com/hzoo/contributors-on-github

screen shot 2017-03-08 at 9 55 49 am

@paulmolluzzo Having seen your mockup, I agree that this is not bad at all.

I'm still not sure whether "Original Poster" should be on the left or on the right side when there's a badge already, but I'm leaning more on keeping the original position of the GitHub badges and adding new ones on the left.

I'm still not sure whether "Original Poster" should be on the left or on the right side when there's a badge already, but I'm leaning more on keeping the original position of the GitHub badges and adding new ones on the left.

Sure. That works fine too.

It's important to note that the user badge is on the left when the comment is left on a line of code. Example: https://github.com/sindresorhus/refined-github/pull/369#discussion_r105855587

I think our custom badge should be where the native ones are, either right or left, depending on context.

@schmuli @jacobbearden @jgierer12 If you haven't done it already, can you contact GitHub support and request this feature?

From the readme:

Our hope is that GitHub will notice and implement some of these much needed improvements. So if you like any of these improvements, please email GitHub support about doing it.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

hkdobrev picture hkdobrev  路  3Comments

fregante picture fregante  路  3Comments

MilesBHuff picture MilesBHuff  路  3Comments

Celthi picture Celthi  路  3Comments

vanniktech picture vanniktech  路  3Comments