Refined-github: Verified commits UI is a bit broken

Created on 17 May 2016  路  5Comments  路  Source: sindresorhus/refined-github

Reproducible on https://github.com/mathiasbynens/dotfiles/commit/adc5b5971649017f4de5b28074e51fcf67ac5b0d

screen shot 2016-05-17 at 12 52 16

The space is too narrow for the Verified badge.

I guess we could restyle that a bit or probably remove the .patch and .diff links if they keep creating problems in that area.

bug

Most helpful comment

I'm still not sold on #224.

I managed to fix the UI by decrementing the font-size by one pixel for each element, the following:

  • .full-commit
  • .full-commit .sha-block
  • .commit .sha-block, .commit .sha

screen shot 2016-05-31 at 15 13 13

All 5 comments

I guess we could restyle that a bit or probably remove the .patch and .diff links if they keep creating problems in that area.

We might have discussed this before, but is there some icon we can use instead to save space? IIRC, we went through the process of shrinking padding to make more room there, so I don't know what else we can do except removing content or rearranging the whole area - like a two row layout.

I'm not keen on either scenario, but if anything gets removed it's the patch/diff links since they're added by RG.

Another idea: We can use keyboard shortcuts to switch to patch/diff of the commit and get rid of the links entirely. + for patch, and = for diff?

I'm open to either shortcuts or icons. I really don't want some of the more obscure things which RG adds to break the default UI. Thanks for the PR, will test it out a bit later today.

@hkdobrev if you can figure out some icon that works well, I'm for that as a solution too. @sindresorhus brought up the point that we might not remember the shortcuts, which is a valid concern. A link is better for something used infrequently.

I'm still not sold on #224.

I managed to fix the UI by decrementing the font-size by one pixel for each element, the following:

  • .full-commit
  • .full-commit .sha-block
  • .commit .sha-block, .commit .sha

screen shot 2016-05-31 at 15 13 13

I'm cool with @sindresorhus's solution if someone wants to make a PR.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

hkdobrev picture hkdobrev  路  3Comments

sindresorhus picture sindresorhus  路  3Comments

shivapoudel picture shivapoudel  路  3Comments

mareksuscak picture mareksuscak  路  3Comments

pawelad picture pawelad  路  3Comments