Recyclerlistview: Pull to refresh lagging.

Created on 14 Nov 2018 · 7Comments · Source: Flipkart/recyclerlistview

I have RLV with RefreshControl and when i refresh, refresh indicator starts to appear and disappear. my RLV jumping. This issue present only with small amount of elements.

`
{ this.state.dataProvider && this.state.data.length > 0 &&

                <RecyclerListView
                    ref={(ref) => this.recyclerView = ref}
                    canChangeSize
                    scrollViewProps={{
                        contentContainerStyle: {paddingBottom: (isIphoneX() ? 140 : 90)},
                        stickyHeaderIndices: [1],
                        refreshControl:  
                            <RefreshControl 
                                refreshing={this.state.refreshing} 
                                onRefresh={async () => {
                                    this.setState({
                                        refreshing: true
                                    });
                                    await this.loadEmployees();
                                    this.setState({
                                        refreshing: false
                                    });
                                }}
                            />
                    }}
                    layoutProvider={this._layoutProvider} 
                    dataProvider={this.state.dataProvider} 
                    rowRenderer={this._rowRenderer}                        
                />    
            }
        </View>

Source

mmamoyco

👍3

Most helpful comment

@LVBK nice job!
After reviewing the source code, i found that _pendingScrollToOffset is used for fix scroll offset after render() called. The _pendingScrollToOffset.y maybe below 0, so in the componentDidUpdate function i add a condition like this:

Hope this defect would be fixed in the next released version.

xmuSistone on 10 Oct 2019

👍5

All 7 comments

Can you provide an expo sample to check?

naqvitalha on 15 Nov 2018

@naqvitalha
When using RLV with small amount items. Then try to pull to refresh on iOS. this bug may appear. Just try many times.
Simulator Screen Shot - iPhone 8 - 2019-10-05 at 11 38 41

LVBK on 5 Oct 2019

@naqvitalha
When i go deep inside RLV source code. Finally i find out _pendingScrollToOffset. It may keep RLV content offset larger than 0 after RLV did update.
I made changed like image below. Please tell me what features will lose or go wrong.
Screenshot 2019-10-05 at 3 29 20 PM