Readthedocs.org: Validate webhook URL

[stsewd]

We have errors like Invalid URL '': No schema supplied. Perhaps you meant http://?

Where users don't put https:// to their urls. We could, add https:// if it wasn't given before save it or ask explicitly to the user to put https?://

ref https://sentry.io/organizations/read-the-docs/issues/789512412/?project=148442&query=is%3Aunresolved

[humitos]

We want to validate the URL when creating a webhook via the Project's Admin -> Notifications -> "New Webhook Notifications"

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[santos22]

👋

Is this still valid? Happy to take a look.

[humitos]

Hey @santos22! Yes. This is valid. Please go ahead and propose a PR :smiling_face_with_three_hearts:

[santos22]

Is there an example of an invalid URL that went through? I don't have access to the Sentry project. Looks like Django assumes 'http' if no scheme is given.

Reference:
https://github.com/django/django/blob/188b003014dc727ca22f7fafb21cf2fa0b3472d2/django/forms/fields.py#L695

[stsewd]

@santos22 you are right, we already use an URLField. I checked the DB and looks like we have some empty values.

We should make that field non-blank/null instead of checking for the protocol https://github.com/readthedocs/readthedocs.org/blob/4e095bf79f7db30e5654466768070da7fe08cfba/readthedocs/projects/models.py#L1448-L1452

[stsewd]

I'll remove those invalid values

[stsewd]

fixed by https://github.com/readthedocs/readthedocs.org/pull/6988