Reactjs.org: Grayscale and excessive margin top affects color-coded images and documentation

Created on 2 Jun 2020  路  6Comments  路  Source: reactjs/reactjs.org

Commit banner applies grayscale on documentation pages, as visible on Thinking in React, which makes the images unclear because the documentation references the image's colors.

Additionally the text is cut off on the bottom because of excessive margin top.

Screen Shot 2020-06-01 at 5 56 25 PM

Screen Shot 2020-06-01 at 5 56 16 PM

I was able to fix the problem locally by undoing the grayscale but I do not have write access to make a PR. (The edits in MarkdownHeader are not causing causing issues) thanks.

Most helpful comment

Thanks for reporting.

I've fixed the blank text problem (seems to be caused by the filter affecting layout).

As for the color-coding, it is unfortunate but we're willing to temporarily leave this broken.

All 6 comments

Came across the same issue while browsing through the Context API documentation, but this somehow seems to be localized to Chrome - this issue is not taking place in Safari or Firefox.

Screenshot from Safari:

Screenshot 2020-06-02 at 11 17 28 PM

Screenshot from Firefox:

Screenshot 2020-06-02 at 11 18 49 PM

Thanks for reporting.

I've fixed the blank text problem (seems to be caused by the filter affecting layout).

As for the color-coding, it is unfortunate but we're willing to temporarily leave this broken.

Is there any way to switch this grayscale filter off to see code highlight? At least for the ppl outside of the US?

As for the color-coding, it is unfortunate but we're willing to temporarily leave this broken.

This disappoints me - when reading documentation, all the syntax highlighting is gray-scale. When I'm reading a manual on how to fix a car, the pages shouldn't turn into black and white because of some external force. As a developer who can see and understand the viewpoints of the BLM movement, it upsets me that it is affecting my ability to see pretty colors.

Is it possible to opt-out of this? I need my pretty colors darn-it!

There is a women who was raped by two cops in Ukraine last week. Let鈥檚 switch colors to yellow-blue. Or you think that her life does not matter?

Is it possible to opt-out of this? I need my pretty colors darn-it!

You can open devtools in the browser then find the CSS rule which begins with * { then add filter: none !important; to it and that will do the trick.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

tajo picture tajo  路  4Comments

gajomon picture gajomon  路  4Comments

VinayakBagaria picture VinayakBagaria  路  3Comments

dstudzinski picture dstudzinski  路  3Comments

tesseralis picture tesseralis  路  3Comments