React: [website] overlapping headers on H1s

Created on 28 Sep 2017  路  6Comments  路  Source: facebook/react

screen shot 2017-09-27 at 4 20 44 pm

/cc @joecritch

Most helpful comment

@acdlite Thanks for the suggestion! I've changed this to 1.7. 1.5 felt too tight in this case, due to the line width. See what you think 馃憤

All 6 comments

This was from http://reactjs.netlify.com/blog/2016/08/05/relay-state-of-the-state.html

It could just be that h1s weren't meant to be used in the body of posts in which case it's the markdown here that should be fixed.

I think @trueadm saw something similar in "optimising performance"

A bit tangential, but I kinda feel like the line-height is too large across the board. Inspecting the body text, the font-size is 18px and the line-height is 35px, or ~2x. I feel somewhere in the range of ~1.5x is typically better. Not enough fits on the screen as-is, IMO.

Thank you, fixed in #10911 馃憤 FYI, the Relay article uses multiple <h1> elements. We should stick to only one of those per page, for aesthetics & accessibility.

@acdlite Thanks for the suggestion! I've changed this to 1.7. 1.5 felt too tight in this case, due to the line width. See what you think 馃憤

Thanks @joecritch!

Was this page helpful?
0 / 5 - 0 ratings