React-virtualized: Strict mode compatibility

Created on 28 Mar 2019  路  10Comments  路  Source: bvaughn/react-virtualized

RV makes use of findDOMNode in WindowScroller and that's deprecated in recent versions of react. You might want to switch this to using refs instead. :)

bug

Most helpful comment

I'd appreciate a fix for this. Thanks for great work!

All 10 comments

@bvaughn can this be addressed? Concurrent mode is coming and it'd be nice if the library worked smoothly with it.

It also seems to be used in CellMeasurer

In WindowScroller, it can be avoided by using registerChild render prop

I'm going to open a PR adding the same pattern for CellMeasurer

UPD: #1477

Even if I use registerChild, WindowScroller doesn't seem to work with StrictMode:

https://codesandbox.io/s/react-virtualized-list-with-width-100-dunc2

You can see that if you scroll list down, new items don't appear. This can mean that there are side effects in places where they shouldn't be

https://reactjs.org/docs/strict-mode.html#detecting-unexpected-side-effects

Thanks for bringing this up! I kinda lost track of some bugs. Will prioritize!

Would be awesome to get the strict mode issue fixed. Thanks for the great work so far!

Hello! Are there any news on this one? Would be awesome to get rid of those warnings cluttering the console :). Thank you for the effort and the nice library!

I'd appreciate a fix for this. Thanks for great work!

This codesandbox example seems to be fixed after upgrading to RV 9.22, maybe it is related to #1477

This codesandbox example seems to be fixed after upgrading to RV 9.22, maybe it is related to #1477

This codesandbox isn't working as of 30/09/20. New items are not being rendered

Was this page helpful?
0 / 5 - 0 ratings

Related issues

wnz99 picture wnz99  路  3Comments

mccambridge picture mccambridge  路  3Comments

johnnyji picture johnnyji  路  3Comments

zllc picture zllc  路  3Comments

miraage picture miraage  路  4Comments