React-sketchapp: Multiple pages are created when using makeSymbol after saving

Created on 15 Feb 2018  路  4Comments  路  Source: airbnb/react-sketchapp

| -------------------------------------------------------------------------------------------------
| Reporting a bug or issue
| -------------------------------------------------------------------------------------------------

Observed behavior:

When using symbols, while running npm run render, every time I save any new changes, a new page is created in sketch. This doesn't happen if makeSymbol is not used, but if makeSymbol was ever used, even if it's removed, it keeps happening unless stopping process and running it again.

How to reproduce:

Run any example that uses makeSymbol like the one @jongold created here, make any change while running live reloading

Sketch version:

48.2

Please attach screenshots, a zip file of your project, and/or a link to your github project

Empty Project
image

After running npm run render, Page 2 is created

image

After saving, Page 3 is created

image

Is this how is supposed to work?

bug

All 4 comments

+1

I believe this is fixed in #235

@mathieudutour I just tested it using changes from pull #235 and I believe still doing the same. I used @alampros git repo to test this if that does any help

Ok so I just found that this only happens when using context.document.currentPage() as the 2nd parameter in render function. Removing that does not create new pages after saving

Was this page helpful?
0 / 5 - 0 ratings