React-sketchapp: Throw error on non-https images

[jongold]

Fun fact - you can only load images over https in Sketch!

We should throw an error if you try to load an image over http.

[agisilaos]

Hey @jongold I would love to work on this! Can you give me more info to start so I can start working on it? Thank you in advance for creating such tool!!

[jongold]

Here's where we're extracting the URL from props and instantiating MSImageData from it

This is the function that actually makes the image data.

I think it might be enough to just shortcircuit that function if the URL doesn't start with https:// or file:// (or maybe better to shortcircuit if it _does_ start with http://). check it doesn't break anything else!

development workflow -

• make a branch, install the dependencies, check npm run check is working
• npm link
• npm run watch to build the library
• cd into one of the examples (or any react-sketchapp project itself), npm install and then npm link react-sketchapp
• make changes, try to break it! testing is kinda brittle due to the nature of it being built upon Sketch!
• if you change any of the examples, please don't commit them!

[agisilaos]

Thanks @jongold I will keep you updated on that one. Oh, it didn't start well. Any idea what is happening here?

[jongold]

looks like you're not in the right directory?

[agisilaos]

@jongold Yup you were right! but after that I got another error... Weird:

[agisilaos]

Nvm, I just fixed it! I had to 'npm update' when I was inside that directory!

[agisilaos]

Ok my progress so far @jongold:

• [x] Make a branch & install dependencies & check npm run check
• [x] npm link
• [x] npm run watch
• [x] cd into one of the examples (or any react-sketchapp project itself), npm install and then npm link react-sketchapp
• [ ] make changes, try to break it! testing is kinda brittle due to the nature of it being built upon Sketch!
• [ ] if you change any of the examples, please don't commit them!

P.s I had some problems with npm and stuff but I fixed them by now. That's what caused the delay.

[jongold]

This is fixed in #111 / 0.11.1 :)