React-native: [0.50] Commits to cherry-pick into stable release

[grabbou]

Please let me know if there's anything you would like to be cherry-picked. Please note we only add fixes (no new features)

[connercms]

Would be nice to have this addressed https://github.com/facebook/react-native/issues/15556

[8of]

Fix for Android TextInput onSubmitEditing next field / submitting behavior , please https://github.com/facebook/react-native/commit/4d54b48167c99d0f3a8917e7637ffe3304c6bed6

Fixes https://github.com/facebook/react-native/issues/16224 and https://github.com/facebook/react-native/issues/16038

[ide]

@connercms The best way to have that issue addressed is to submit a high-quality PR (simple, easy to maintain, appropriately engineered), have it land in master, and then cherry-pick it back. This issue here is just for cherry-picks.
@8of https://github.com/facebook/react-native/commit/4d54b48167c99d0f3a8917e7637ffe3304c6bed6 is already in 0.50.0-rc.0 and will be part of 0.50.

[ide]

Added https://github.com/facebook/react-native/commit/7733d4023728f32a940e9e4a31f79e70455871a8 to 0.50-stable so that RNW can override ReactNativeVersionCheck (@rozele this is a commit for the proposal we discussed, it will go out with 0.50).

[grabbou]

I am waiting for https://github.com/facebook/react-native/pull/15460 to land before shipping 0.50 next RC. It's not an exception as this was meant to be part of 0.49 and was delayed due to longer review.

I would like to test new Circle 2.x setup that uses hold before deploying feature and to make sure none of the recent Ci changes broke the release process. If that's okay, I would request everyone interested in next RC to wait one more day :)

[akshetpandey]

Would be great if proguard started working without modifications again...
PR: https://github.com/facebook/react-native/pull/15619

[ide]

Added https://github.com/facebook/react-native/commit/ce937e5b3f630c5e66e583fa0912868ad1818486, which fixes progress bars on Android that were mistakenly rendered as activity indicators.

[grabbou]

Added 74146cb, which adds Cocoapods support to react-native link. Branch is now clear for release, will be doing that in a bit.

[ide]

I backed out https://github.com/facebook/react-native/commit/ce937e5b3f630c5e66e583fa0912868ad1818486 and replaced it with b60fa63de842a6745a795f78b316ce463604e418, which fixes an additional warning. I had to force push so if you pull 0.50-stable and already have it checked out you'll need to force pull.

[aligfl]

it would be really helpful if #15556 was addressed.

[akshetpandey]

15619 has be replaced with #16486

Since the first PR was closed because it pointed to the wrong branch.

[felippepuhle]

Waiting for this one: https://github.com/facebook/react-native/commit/30044fd531c22c4c5e8f1ede206fa7c2c3fd3aa8

Thanks!

[grabbou]

@aligfl please report only commits merged to master in this issue to make it easier for us to operate on the releases.

@akshetpandey thanks for the PR, but it's not yet merged, and so - no cherry-picking.

@felippepuhle commit you linked is already part of release (0.50.x)

[SeMeKh]

It'd be nice to have https://github.com/facebook/react-native/commit/c278020633119b0c20752593666b0e8536f6a4b1 which I assume fixes https://github.com/facebook/react-native/issues/13100.

[grabbou]

I've picked it and released rc-2 just now. Please test it @SeMeKh and let me know if it works. I need this feedback before releasing stable :)

[SeMeKh]

Thanks a lot @grabbou, but v0.50.0-rc.2 does not seem to be available on npm yet. Am I missing something?

[grabbou]

Yeah, it's async process. When I said I released, I actually meant i
scheduled release on Circleci. When build goes green, npm will report
latest version. That usually takes an half an hour if there are no major
mistakes.

On Mon, 30 Oct 2017, 11:15 am Mehran Kholdi, [e-mail]
wrote:

Thanks a lot @grabbou https://github.com/grabbou, but v0.50.0-rc.2 does
not seem to be available on npm yet. Am I missing something?

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/16257#issuecomment-340400582,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWcxgBLLUrzjy4BRL-wEDwYmxYJAyLWks5sxaHEgaJpZM4PyoqY
.

[SeMeKh]

Looks like the build has failed, but it looks like a false negative (Unable to download: mvn:org.robolectric:android-all:jar:4.1.2_r1-robolectric-0)
https://circleci.com/gh/facebook/react-native/24491#tests/containers/0
Will you please trigger a rebuild?

[grabbou]

Yeah, just did it.

On Mon, 30 Oct 2017 at 11:29 Mehran Kholdi [e-mail] wrote:

Looks like the build has failed, but it looks like a false negative (Unable
to download: mvn:org.robolectric:android-all:jar:4.1.2_r1-robolectric-0)
https://circleci.com/gh/facebook/react-native/24491#tests/containers/0
Will you please trigger a rebuild?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/16257#issuecomment-340403889,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWcxqF3M6LSUnxODvER2mO56qjXDEhuks5sxaULgaJpZM4PyoqY
.

[SeMeKh]

Awesome! Tested with rc.2 and the bugfix is working as intended.

[grabbou]

Thanks, I'll be promoting this to stable around tomorrow as soon as I wrap
the changelog up.

On Mon, 30 Oct 2017, 3:36 pm Mehran Kholdi, [e-mail]
wrote:

Awesome! Tested with rc.2 and the bugfix is working as intended.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/16257#issuecomment-340462754,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWcxs04xZbDVZtNsGAWVzd2DMxe-gPWks5sxd7rgaJpZM4PyoqY
.

[mackenzie-gray]

Would be amazing if this was addressed: #10999

[dharik]

12403 🥇

I think this is one of the referenced commits:

https://github.com/facebook/react-native/commit/875f273dbaf1b6f351d2fedfdf829a847ae58776

875f27

[ide]

The cherry-pick list is primarily for high-priority bug fixes. Nice-to-have features will go out with the next release -- one reason why we have a monthly release cycle, which is more frequent than most projects' -- let alone open issues or unmerged PRs.

[grabbou]

I am going to close this one as there are no new commits to be cherry-picked into 0.50. I'll be working on a changelog now and the release will be later promoted to stable. In the meantime, I am going to cut 0.51 branch where all the commits that I haven't cherry-picked yet are going to be available.