React-native-ui-kitten: please support rn 0.56

Created on 14 Jul 2018  路  7Comments  路  Source: akveo/react-native-ui-kitten

rt.

Bug

Most helpful comment

@zshchou All I had to do to get it to work was change node_modules/react-native-ui-kitten/src/components/image/rkModalImg.js line 283 from: ...imgProps, to: ...imgProps
I haven't had any issues yet.

All 7 comments

Hi @zshchou,

We'll work on upgrading as soon as expo will support it and currently we're not able to do it.
Thanks

@zshchou All I had to do to get it to work was change node_modules/react-native-ui-kitten/src/components/image/rkModalImg.js line 283 from: ...imgProps, to: ...imgProps
I haven't had any issues yet.

I realized today while writing a script to fix this that Prettier is changing my line numbers. Basically what you need to do is remove the trailing commas:

A,
B,
C, <-- Wrong

A,
B,
C <-- Right

I still haven't had any issues.
react-native-ui-kitten 3.0.1
react-native 0.56

@LouisIV
Thanks for suggestion.
Also if you don't use prettier but use eslint, you can do the following:
https://github.com/eslint/eslint/issues/7297

You can run the following command manually or add to your npm scripts until this is resolved.

sed -i -e 's/...imgProps,/...imgProps/g' node_modules/react-native-ui-kitten/src/components/image/rkModalImg.js

yarn add https://github.com/akveo/react-native-ui-kitten.git, it's work for me.

or generate a new tag/version, because the rkModalImg.js, don't have the comma, look:

https://github.com/akveo/react-native-ui-kitten/blob/master/src/components/image/rkModalImg.js#L323

Fixed in v3.1.0

Was this page helpful?
0 / 5 - 0 ratings

Related issues

domsterthebot picture domsterthebot  路  3Comments

RWOverdijk picture RWOverdijk  路  3Comments

Gitldx picture Gitldx  路  3Comments

chamatt picture chamatt  路  3Comments

domsterthebot picture domsterthebot  路  3Comments