React-native-navigation: [V2] Android hard crash without warning when a bottom tab icon isn't set

[kyle-ssg]

Issue Description

Tab based app crashes without warning

Navigation.setRoot({
    root: {
        bottomTabs: {
            children: [
                {
                    component: {
                        name: '/',
                        options: {
                            bottomTab: {
                                text: 'Tab 2',
                            },
                        },
                    },
                },
            ],
        },
    },
});

Steps to Reproduce / Code Snippets / Screenshots

02-04 10:59:17.060  2300 21677 W ErrorReporter: reportError [type: 211, code: 524300]: Error reading from input stream
02-04 10:59:17.066  2300  2805 I MicroRecognitionRunner: Stopping hotword detection.
02-04 10:59:17.067  2300 21677 W ErrorProcessor: onFatalError, processing error from engine(4)
02-04 10:59:17.067  2300 21677 W ErrorProcessor: com.google.android.apps.gsa.shared.speech.b.g: Error reading from input stream
02-04 10:59:17.067  2300 21677 W ErrorProcessor:    at com.google.android.apps.gsa.staticplugins.recognizer.j.a.a(SourceFile:28)
02-04 10:59:17.067  2300 21677 W ErrorProcessor:    at com.google.android.apps.gsa.staticplugins.recognizer.j.b.run(SourceFile:15)
02-04 10:59:17.067  2300 21677 W ErrorProcessor:    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:457)
02-04 10:59:17.067  2300 21677 W ErrorProcessor:    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
02-04 10:59:17.067  2300 21677 W ErrorProcessor:    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:457)
02-04 10:59:17.067  2300 21677 W ErrorProcessor:    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
02-04 10:59:17.067  2300 21677 W ErrorProcessor:    at com.google.android.apps.gsa.shared.util.concurrent.a.ag.run(Unknown Source:4)
02-04 10:59:17.067  2300 21677 W ErrorProcessor:    at com.google.android.apps.gsa.shared.util.concurrent.a.bo.run(SourceFile:4)
02-04 10:59:17.067  2300 21677 W ErrorProcessor:    at com.google.android.apps.gsa.shared.util.concurrent.a.bo.run(SourceFile:4)
02-04 10:59:17.067  2300 21677 W ErrorProcessor:    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
02-04 10:59:17.067  2300 21677 W ErrorProcessor:    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
02-04 10:59:17.067  2300 21677 W ErrorProcessor:    at java.lang.Thread.run(Thread.java:764)
02-04 10:59:17.067  2300 21677 W ErrorProcessor:    at com.google.android.apps.gsa.shared.util.concurrent.a.ak.run(SourceFile:6)
02-04 10:59:17.067  2300 21677 W ErrorProcessor: Caused by: com.google.android.apps.gsa.shared.exception.GsaIOException: Error code: 393238 | Buffer overflow, no available space.
02-04 10:59:17.067  2300 21677 W ErrorProcessor:    at com.google.android.apps.gsa.speech.audio.Tee.f(SourceFile:103)
02-04 10:59:17.067  2300 21677 W ErrorProcessor:    at com.google.android.apps.gsa.speech.audio.au.read(SourceFile:2)
02-04 10:59:17.067  2300 21677 W ErrorProcessor:    at java.io.InputStream.read(InputStream.java:101)
02-04 10:59:17.067  2300 21677 W ErrorProcessor:    at com.google.android.apps.gsa.speech.audio.ao.run(SourceFile:18)
02-04 10:59:17.067  2300 21677 W ErrorProcessor:    at com.google.android.apps.gsa.speech.audio.an.run(SourceFile:2)
02-04 10:59:17.067  2300 21677 W ErrorProcessor:    ... 11 more

---

Environment

• React Native Navigation version: 2.8.0
• React Native version: 0.57.8
• Platform(s) (iOS, Android, or both?): Android
• Device info (Simulator/Device? OS version? Debug/Release?): All

[rawrmaan]

Tab bars without icons aren't an intended use case. I would recommend closing this as it's really a non-issue.

[kyle-ssg]

Fair enough I guess, though at least it should document that they are required. Developing the app iOS first the whole app worked, then I was faced with this non-descriptive error on android - I only figured this out by chance. It would be trivial to throw an error JS side.

[kyle-ssg]

https://github.com/wix/react-native-navigation/issues/4534 Duplicate, think this needs addressing seeing I'm clearly not the only one who fell for this.

[MakhouT]

Thank God I stumbled on this, I also have this issue!

[xxRockOnxx]

@guyca Can we at least pin this issue? It was really hard to tell why the app crashes unless you stumbled upon this issue