React-native-navigation: Sidemenu keeps openning on android

[suupham2506]

Issue Description

I pressed on OPEN SIDEMENU button, then I closed it. I switch to tab Flatlist, when I switch back to SideMenu tab, the sidemenu kept openning.

This is playground example project.

Steps to Reproduce / Code Snippets / Screenshots

---

Environment

• React Native Navigation version: FILL THIS OUT
• React Native version: FILL THIS OUT
• Platform(s) (iOS, Android, or both?): FILL THIS OUT
• Device info (Simulator/Device? OS version? Debug/Release?): FILL THIS OUT

[StasDoskalenko]

@suupham2506 I've fixed in this way: https://github.com/StasDoskalenko/react-native-navigation/commit/620733ba1bc35a5a2fc995bc13c1d517ceb4aca5

[sorinfratila]

I fixed this by just mentioning the sideMenu id in the global listener: this is what I pass to:

registerNavigationButtonPressedListener(this.onNavigatorEvent)

onNavigatorEvent = (event) => { switch (event.buttonId) { case 'menu': { Navigation.mergeOptions('MENU', { sideMenu: { right: { visible: true, }, }, }); break; } } }

So in mergeOptions I basically pass the id directly ('MENU'), instead of reading event.componentId;

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

[retyui]

Up

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

[guyca]

@retyui Is this issue still reproducing for you? I think it's fixed by https://github.com/wix/react-native-navigation/commit/43f05ee01574c18d216acfb510be4b5e38165e4d

[retyui]

@guyca
I could not reproduce the problems, RN 2.16