React-native-navigation: V2 - 2.3.0 bottomTabs bug

Created on 24 Dec 2018  ·  24Comments  ·  Source: wix/react-native-navigation

there is bug in new commit in 2.3.0 bottomTabs

initmobile\node_modules\react-native-navigation\lib\android\app\src\main\java\com\reactnativenavigation\views\BottomTabs.java:33: error: method does not override or implement a method from a supertype
    @Override
    ^
\initmobile\node_modules\react-native-navigation\lib\android\app\src\main\java\com\reactnativenavigation\views\BottomTabs.java:48: error: createItems() has private access in AHBottomNavigation
        super.createItems();
             ^
\initmobile\node_modules\react-native-navigation\lib\android\app\src\main\java\com\reactnativenavigation\viewcontrollers\bottomtabs\BottomTabsController.java:150: error: no suitable constructor found for AHBottomNavigationItem(String,Drawable,String)
            return new AHBottomNavigationItem(
                   ^
    constructor AHBottomNavigationItem.AHBottomNavigationItem(String,int,int) is not applicable
      (argument mismatch; Drawable cannot be converted to int)
    constructor AHBottomNavigationItem.AHBottomNavigationItem(int,int,int) is not applicable
      (argument mismatch; String cannot be converted to int)
    constructor AHBottomNavigationItem.AHBottomNavigationItem(String,Drawable,int) is not applicable
      (argument mismatch; String cannot be converted to int)
Note: C:\Users\Amin\Desktop\gittick\initmobile\node_modules\react-native-navigation\lib\android\app\src\reactNative57_5\java\com\reactnativenavigation\react\SyncUiImplementation.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: Some messages have been simplified; recompile with -Xdiags:verbose to get full output
3 errors

i should mention that, it works by returning to 2.2.5

Most helpful comment

same issue!!!:

Task :react-native-navigation:compileReactNative57DebugJavaWithJavac FAILED
/Users/guillermo/Documents/projects/react_native/njoyv3/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativen
avigation/views/BottomTabs.java:33: error: method does not override or implement a method from a supertype
@Override
^
/Users/guillermo/Documents/projects/react_native/njoyv3/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/views/BottomTabs.java:48: error: createItems() has private access in AHBottomNavigation
super.createItems();
^
/Users/guillermo/Documents/projects/react_native/njoyv3/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/bottomtabs/BottomTabsController.java:150: error: no suitable constructor found for AHBottomNavigationItem(String,Drawable,String)
return new AHBottomNavigationItem(
^
constructor AHBottomNavigationItem.AHBottomNavigationItem(String,int,int) is not applicable
(argument mismatch; Drawable cannot be converted to int)
constructor AHBottomNavigationItem.AHBottomNavigationItem(int,int,int) is not applicable
(argument mismatch; String cannot be converted to int)
constructor AHBottomNavigationItem.AHBottomNavigationItem(String,Drawable,int) is not applicable
(argument mismatch; String cannot be converted to int)
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: Some messages have been simplified; recompile with -Xdiags:verbose to get full output
3 errors

"react-native": "^0.57.8",
"react-native-navigation": "^2.5.0",

All 24 comments

Hey, you probably didn't recompile after npm installing.

Same here..!
App was working fine on oreo but when i upgrader to Android Pie it stopped working why ?
Please help. !
Does RNN support android pie ?
@guyca

same issue!!!:

Task :react-native-navigation:compileReactNative57DebugJavaWithJavac FAILED
/Users/guillermo/Documents/projects/react_native/njoyv3/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativen
avigation/views/BottomTabs.java:33: error: method does not override or implement a method from a supertype
@Override
^
/Users/guillermo/Documents/projects/react_native/njoyv3/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/views/BottomTabs.java:48: error: createItems() has private access in AHBottomNavigation
super.createItems();
^
/Users/guillermo/Documents/projects/react_native/njoyv3/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/bottomtabs/BottomTabsController.java:150: error: no suitable constructor found for AHBottomNavigationItem(String,Drawable,String)
return new AHBottomNavigationItem(
^
constructor AHBottomNavigationItem.AHBottomNavigationItem(String,int,int) is not applicable
(argument mismatch; Drawable cannot be converted to int)
constructor AHBottomNavigationItem.AHBottomNavigationItem(int,int,int) is not applicable
(argument mismatch; String cannot be converted to int)
constructor AHBottomNavigationItem.AHBottomNavigationItem(String,Drawable,int) is not applicable
(argument mismatch; String cannot be converted to int)
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: Some messages have been simplified; recompile with -Xdiags:verbose to get full output
3 errors

"react-native": "^0.57.8",
"react-native-navigation": "^2.5.0",

This is also happening to me on latest 2.6.0 version. I've cleaned and rebuilt my Android project multiple times, no luck.

any luck on this? same issue on version 2.7. iOS works well.

Nope..
Sadly Moved to react navigation

On Mon, Jan 21, 2019, 11:22 PM Jan Roures Mintenig notifications@github.com
wrote:

any luck on this? same issue on version 2.7. iOS works well.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/wix/react-native-navigation/issues/4498#issuecomment-456154683,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHOlLEO2E8iRjbebVphyHvWa7I0zsj6Eks5vFf5QgaJpZM4ZgkP8
.

check whether com.github.wix-playground:ahbottomnavigation's version under node_modules/react-native-navigation/lib/android/app/build.gradle is 2.4.6?

it is 2.4.8. should that matter?

should be okay

have you faced the issue before?

yes, i was using latest version but somehow i found that the ahbottomnavigation version is not correct, after manually update it everything works again

you downgraded from 2.4.8 to 2.4.6?

nope, was 2.3.x

oh okay. I'm facing the issue with 2.4.8 :/

Facing the same issue here.

which version of com.github.wix-playground:ahbottomnavigation's under node_modules/react-native-navigation/lib/android/app/build.gradle are you using?

@janroures The react-native-navigation is referring to com.github.wix-playground:ahbottomnavigation:2.4.5. If i change to the latest tag 2.4.8 from https://github.com/wix-playground/ahbottomnavigation/releases, everything seems to be working fine.

🤔

after installing and trying different versions and everything worked fine when I got back to 2.4.8

Yea. i updated to the latest release 2.7.1-snapshot.159 and it worked.

👍

Same problem here on 2.7.1 and also on 2.7.1-snapshot.160 on a colleague's setup. Works fine by rollbacking to 2.5.1!
react-native version is 0.57.8.

All versions works fine on my computer though...

There are few cache's going on here. You may have to clean your gradle cache too.

rm -rf ~/.gradle/cache

still facing the same issue with 2.4.9 version and I just created a fresh app from cli
React native: 0.58.6
react native navigation: 2.13.1

any updates on this ?

I found i missed to add jitpack repository. Add this tho your project level build.gradle and hit sync again.

allprojects {
    repositories {
        // <other repos>
        maven {
            url 'https://jitpack.io'
        }
    }
}

upgrade Android Gradle plugin to 3.3.2 works for me: https://developer.android.com/studio/releases/gradle-plugin

in anroid/build.gradle,
~
dependencies {
classpath 'com.android.tools.build:gradle: 3.3.2'
}
~

RN: 0.59.3
react-native-navigation: 2.16.0

Was this page helpful?
0 / 5 - 0 ratings