React-native-navigation: [v2] searchBar: false render a searchBar on iOS 11+

Created on 12 Dec 2018  路  35Comments  路  Source: wix/react-native-navigation

Issue Description

searchBar: false renders a search bar on iOS 11+.

Steps to Reproduce / Code Snippets / Screenshots

Create a component with the following definition.

{
  component: {
  id: "a.component",
  name: "a.component",
  options: {
    topBar: {
      searchBar: false,
      title: {
        text: "Search Bar is Visible,
      },
    },
  },
}

Without searchBar: false there is no search bar, with searchBar: any, a wild search bar appears.

This is due to https://github.com/wix/react-native-navigation/blob/b0c8113243de2043b98442dd485c04b0422aa213/lib/ios/RNNViewControllerPresenter.m#L31 just checking if there is a value instead of making sure the value is truthy.

I wanted to do a PR, but it's also present here https://github.com/wix/react-native-navigation/blob/b0c8113243de2043b98442dd485c04b0422aa213/lib/ios/RNNViewControllerPresenter.m#L67 and I wasn't sure how to handle removing the search bar.

Environment

  • React Native Navigation version: 2.1.3-snapshot.50
  • React Native version: 0.56
  • Platform(s) (iOS, Android, or both?): iOS
  • Device info (Simulator/Device? OS version? Debug/Release?): iOS 11+
picture dozoisch
👍2

Most helpful comment

馃拑 not stale

picture dozoisch on 8 Nov 2019
😄2

All 35 comments

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

stale[bot] picture stale[bot] on 12 Jan 2019

Not stale.

mathieumg picture mathieumg on 12 Jan 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

stale[bot] picture stale[bot] on 11 Feb 2019

Not stale :)

dozoisch picture dozoisch on 11 Feb 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

stale[bot] picture stale[bot] on 13 Mar 2019

Not stale

mathieumg picture mathieumg on 13 Mar 2019
👍1

Not stale. Affects latest 2.17.0 also

alexey-chernikov picture alexey-chernikov on 12 Apr 2019
👍2

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

stale[bot] picture stale[bot] on 12 May 2019

Not stale.

mathieumg picture mathieumg on 12 May 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

stale[bot] picture stale[bot] on 11 Jun 2019

Not stale.

mathieumg picture mathieumg on 11 Jun 2019
👍1

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

stale[bot] picture stale[bot] on 11 Jul 2019

Not stale!

dozoisch picture dozoisch on 11 Jul 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

stale[bot] picture stale[bot] on 10 Aug 2019

Not stale

dozoisch picture dozoisch on 10 Aug 2019
👍1

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

stale[bot] picture stale[bot] on 9 Sep 2019

Not stale.

mathieumg picture mathieumg on 9 Sep 2019
👀1

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

stale[bot] picture stale[bot] on 9 Oct 2019

Not stale.

mathieumg picture mathieumg on 9 Oct 2019
🚀1

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

stale[bot] picture stale[bot] on 8 Nov 2019

馃拑 not stale

dozoisch picture dozoisch on 8 Nov 2019
😄2

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

stale[bot] picture stale[bot] on 8 Dec 2019

Not stale.

mathieumg picture mathieumg on 9 Dec 2019

I could submit a PR if anyone would point me in the right direction - I wonder whether setting UIViewController's navigationItem.searchController to nil would suffice

simonasdev picture simonasdev on 20 Dec 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

stale[bot] picture stale[bot] on 19 Jan 2020

Not stale

dozoisch picture dozoisch on 21 Jan 2020

Still not stale...

captaincole picture captaincole on 16 Feb 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest version and report back. Thank you for your contributions.

stale[bot] picture stale[bot] on 17 Mar 2020

not stale

dozoisch picture dozoisch on 17 Mar 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest version and report back. Thank you for your contributions.

stale[bot] picture stale[bot] on 17 Apr 2020

not stale

dozoisch picture dozoisch on 17 Apr 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest version and report back. Thank you for your contributions.

stale[bot] picture stale[bot] on 17 May 2020

not stale

dozoisch picture dozoisch on 17 May 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest version and report back. Thank you for your contributions.

stale[bot] picture stale[bot] on 17 Jun 2020

not stale

dozoisch picture dozoisch on 17 Jun 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

ruslan-bikkinin picture ruslan-bikkinin  路  36Comments
brunolemos picture brunolemos  路  50Comments
maurovisintin picture maurovisintin  路  101Comments
harveyconnor picture harveyconnor  路  57Comments
L-Yeiser picture L-Yeiser  路  34Comments