React-native-keychain: Memory leaks in iOS

[binkumar]

When I'm using below code in my app.

Keychain.getGenericPassword()
      .then(credentials => {
        if (credentials) {
          this.setState({
            password: credentials.password
          });
        } else {
          return Keychain.setGenericPassword(
            'test',
            'randomSecret'
          ).then(() => {
            this.setState({
              password: 'test'
            });
            Promise.resolve('randomSecret')
          });
        }
      })
      .catch(error => {
        this.setState({
          password: error.message
        });
        Promise.reject(error)
      });

I'm getting memory leaks. I'm using Xcode instrumentation to identify this leaks. See attached screenshots.


This leaks increases continuously until the app is an active.

Below is the app leak area.
OSStatus osStatus = SecItemCopyMatching((__bridge CFDictionaryRef) query, (CFTypeRef*)&foundTypeRef);

Let me know whether I'm doing anything wrong.

[rajivshah3]

I'm seeing this as well. I found an answer on StackOverflow that seems to explain the issue. Here's an excerpt:

You receive the keychain object from a CF-style function with Copy in its name. Therefore it has a +1 reference count, and you have the responsibility of explicitly releasing it when you're done using it. It is never released by your sample code, so it's leaking.

Screenshot of the leak from my app:

That could be the problem here, because Instruments is showing Retain & Release Count: +1. Once we're done with osStatus, maybe CFRelease(osStatus) will do the trick?

[Bautista-Baiocchi-lora]

Is there a fix for this?

[rajivshah3]

@Bautista-Baiocchi-lora when I have some time I'll try the CFRelease(osStatus) to see if it resolves the issue. I'm not very experienced with memory management though, so I'm not sure if this is the correct fix. @oblador do you know if this is the right approach?

[rajivshah3]

Update: The leak was actually coming from foundTypeRef, which is a Core Foundation object that we created but didn't release after we were done using it. I fixed it in #188

[binkumar]

@rajivshah3 Thanks for fixing the issue.

[Bautista-Baiocchi-lora]

Update: The leak was actually coming from foundTypeRef, which is a Core Foundation object that we created but didn't release after we were done using it. I fixed it in #188

Great find! Thank you for the fix.