React-native-deck-swiper: a strange issue

[lzctbyong]

it causes a issue when i move the object , release ,and click the object quickly,
the object will stay an incorrect positon
such as :

[lzctbyong]

By the way , Thank you for the nice comonpent

[lzctbyong]

Can move right it increases and move left it decreases?

[alexbrillant]

Are you using the latest version of RN? I cannot reproduce with react-native v0.43.3.

[alexbrillant]

I have seen this issue before with a previous version of RN, but I can't remember which one it is.

[lzctbyong]

@alexbrillant RN 0.44

[alexbrillant]

@lzctbyong Does this bug occur only on android?

[lzctbyong]

@alexbrillant My Platform is Android, I didn't test IOS ,I guess it's an issue about PanResponder
Do you have this issue?

[alexbrillant]

@lzctbyong Are you using the latest version of this package (1.1.6) ?

[alexbrillant]

@lzctbyong I haven't tested it on 0.44 yet, and I cannot reproduce the bug on my current test project. I will try to find time today to test it. I think that using updateNativeStyles() instead of Animated.Event could do the trick. This is what they use in the example. A pull request would be cool. https://facebook.github.io/react-native/docs/panresponder.html

[lzctbyong]

@alexbrillant it's latest (1.1.6), I try to find more information about the issue for you

[lzctbyong]

@alexbrillant I find the code for the issue:

onPanResponderGrant = ( event , gestureState ) => { console.log('Swiper(93):::onPanResponderGrant---->',) this.state.pan.setOffset( { x: this._animatedValueX , y: this._animatedValueY } ) this.state.pan.setValue( { x: 0 , y: 0 } ) }

if the code likes this ,it would be OK
this.state.pan.setOffset( { x: this._animatedValueX , y: this._animatedValueY } )
==>
this.state.pan.setOffset( { x: 0, y: 0 } )

What do you think about it ??

[alexbrillant]

@lzctbyong thanks for the help. if you want to be a contributor, you can fork my repo, and submit a pull request. Otherwise, I will test it out tonight, and publish it if it works

[alexbrillant]

Cannot reproduce in ios

[lzctbyong]

@alexbrillant So Funny , I would test the iOS Platform when I'm free

[alexbrillant]

@lzctbyong Cannot reproduce on android either.

[alexbrillant]

Ohh, I get it now. You have to tap really quick on the element while it is being swiped haha. Okey, I think I know how to fix this !

[lzctbyong]

@alexbrillant Right! you found it finally

[alexbrillant]

Thanks ! I'm sorry I couldn't understand your issue before :p

[lzctbyong]

My English is poor , so that I can't describe the details too much .
It's not your problem ,You can close the issue after you fix it .

[alexbrillant]

@lzctbyong fixed in v1.1.7 ! 👍