React-native-deck-swiper: Invalid width of type string supplied to overlayLabelWrapper

Created on 5 Oct 2017  Â·  6Comments  Â·  Source: alexbrillant/react-native-deck-swiper

Happens with the basic example from README:

screen shot 2017-10-05 at 12 33 42

Props width and height shouldn't be of type string as described here:
https://github.com/alexbrillant/react-native-deck-swiper#overlaylabelwrapperstyle-default-props

Wouldn't it be better to use flexbox and use alignSelf: 'stretch' ?

Most helpful comment

@miclaus I see, apologies.

@alexbrillant Looks like we should bump RN in package.json to 0.42.3. See: https://github.com/facebook/react-native/releases/tag/v0.42.3

All 6 comments

@miclaus Which version of RN do you use? Percentages landed early this year.

Flexbox vs absolute positioning have been covered. TL;DR: There are things that are possible with absolute positioning that can't be reproduced using flexbox alone.

@designorant i'm using the the same version specified in package.json that being 0.41.2.

i tested it using alignSelf: 'stretch' and it worked fine for me, but i still have to figure something out for the height of the cards.

@miclaus I see, apologies.

@alexbrillant Looks like we should bump RN in package.json to 0.42.3. See: https://github.com/facebook/react-native/releases/tag/v0.42.3

@designorant no worries, thank's for the version tip, i'll give that a try.

@designorant bumped rn peer dependencies and examples rn version in 1.4.2

@alexbrillant isn't that quite a sudden high jump from the previous React and RN versions ?
(ref https://github.com/alexbrillant/react-native-deck-swiper/commit/29e2c7ec3dda4286793b61977724fdd2472af61a#diff-b9cfc7f2cdf78a7f4b91a753d10865a2)

a minimum supported React and RN version should be chosen, instead of the latest – or am i mistaken here ?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

acesetmatch picture acesetmatch  Â·  8Comments

KoheiTigers picture KoheiTigers  Â·  7Comments

kevinmcalear picture kevinmcalear  Â·  6Comments

georgeMorales picture georgeMorales  Â·  4Comments

clay-morgan picture clay-morgan  Â·  4Comments